From dev-return-6934-apmail-continuum-dev-archive=continuum.apache.org@continuum.apache.org Tue May 06 20:30:18 2008 Return-Path: Delivered-To: apmail-continuum-dev-archive@www.apache.org Received: (qmail 91268 invoked from network); 6 May 2008 20:30:18 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 6 May 2008 20:30:18 -0000 Received: (qmail 15743 invoked by uid 500); 6 May 2008 20:30:20 -0000 Delivered-To: apmail-continuum-dev-archive@continuum.apache.org Received: (qmail 15712 invoked by uid 500); 6 May 2008 20:30:19 -0000 Mailing-List: contact dev-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list dev@continuum.apache.org Received: (qmail 15701 invoked by uid 99); 6 May 2008 20:30:19 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2008 13:30:19 -0700 X-ASF-Spam-Status: No, hits=2.0 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of emmanuel.venisse@gmail.com designates 74.125.46.157 as permitted sender) Received: from [74.125.46.157] (HELO yw-out-1718.google.com) (74.125.46.157) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 May 2008 20:29:32 +0000 Received: by yw-out-1718.google.com with SMTP id 9so1227959ywk.50 for ; Tue, 06 May 2008 13:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; bh=MdzQl1v8xUDYZM9PUEbdBz1eszmhsF1TRszONJWxI1s=; b=xoBZmK6dFWea44eLSkCQrXfVh9OV0gcmVHla1Gorqfs5xyDBNumPIYAKjpqqtzmDQ/nr2c+rJTohf8kHsvYBUAuZfDjT9vCzltzNrpCXCjJYpLA0Dse4A5KruekyHHgToYCjGrcOAjQ08KU3f/oJIkXBKOfi15XlPIMQjpUY6ZM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:references; b=XaFjfdx5HCrpDqNmd3K0XnGjqaczkxg5esKrx6IW4I+PvxqjLe2Wrgd3crzsyhS56tz82cuASWoKQOcrzZFuItpRO7r94pqBKORLWdRpQj34vOy70U1vabomnA3mOnbz+5HTMiN9qhh7w2kjL1NhyQAujJcMLiBjrdsVKnurt3w= Received: by 10.150.73.6 with SMTP id v6mr1250996yba.117.1210105781265; Tue, 06 May 2008 13:29:41 -0700 (PDT) Received: by 10.70.40.1 with HTTP; Tue, 6 May 2008 13:29:41 -0700 (PDT) Message-ID: Date: Tue, 6 May 2008 22:29:41 +0200 From: "Emmanuel Venisse" To: dev@continuum.apache.org Subject: Re: refactoring the SCM In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_17704_12512981.1210105781266" References: <3AD39409-CACE-4134-A481-5775E8B0DA30@apache.org> <9948cb690804291452q584638d2wb84a032d853bfa90@mail.gmail.com> <3AC8634F-4704-4C76-86A1-EC76BA94FFFC@apache.org> X-Virus-Checked: Checked by ClamAV on apache.org ------=_Part_17704_12512981.1210105781266 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi Brett, Great work, I like it and I'm ok to merge it regularly to trunk. I don't have idea about maps of beans. I think this branch is a good start to do more refactoring. 1- split DefaultBuildController to a controller + a builder The builder should be in it's own module and doesn't use/know the store, it checkout/update the working copy and build the project The controller get an event from the UI, the scheduler or an other way and send and event to one or more builder (local or remote), JMS is probably the solution 2- for each steps, the builder send the new project state notification, by JMS too and the Controller store it in memory, The project state must be transient instead of to store it in the db like today. When the build is done, the builder send a new event with the build result I have a point that I don't know for the moment how to resolve. How to access to the working copy when the builder is a remote builder and how to do when we use more than one remote builder? But we'll can find a solution later. Emmanuel On Tue, May 6, 2008 at 3:37 AM, Brett Porter wrote: > ok, fixed and committed :) > > Anyone able to take a look through? > > Cheers, > Brett > > > On 02/05/2008, at 2:53 PM, Brett Porter wrote: > > me too after cleaning up. Sorry about that, I'll look into it. > > > > - Brett > > > > On 30/04/2008, at 5:52 AM, Olivier Lamy wrote: > > > > Hi, > > > I can't build the branch : > > > > > > /local/olamy/open-source/continuum-svn/builder-branch/continuum-core/src/main/java/org/apache/maven/continuum/core/action/AddProjectToCheckOutQueueAction.java:[60,16] > > > cannot find symbol > > > symbol : class CheckOutTask > > > location: class > > > org.apache.maven.continuum.core.action.AddProjectToCheckOutQueueAction > > > > > > > > > 2008/4/27 Brett Porter : > > > > > > > Hi, > > > > > > > > I've started to do some refactoring - this is along the way to the > > > > builder > > > > separation I mentioned earlier. > > > > > > > > If you have a moment, please review r 651947. It's on a branch, but > > > > I'd > > > > like to regularly merge to trunk if there are no objects to avoid > > > > getting > > > > too distant. I have more tests to write for this first. > > > > > > > > All I've done is pulled the DefaultContinuumScm class out into a > > > > separate > > > > module, and decoupled it from the model. It already contained some > > > > logic > > > > related to the SCMs (which may actually need to go back into Maven > > > > SCM > > > > itself). I pulled the logging and database updates back into the > > > > actions in > > > > code (this did result in some duplication, but I can clean that up > > > > later). > > > > It also showed that some code was never having its results used, and > > > > also > > > > started to expose some exception handling bugs. I stopped wrapping > > > > exceptions and results, choosing to use the Maven SCM API natively. > > > > > > > > Thoughts? > > > > > > > > Anyone that is knowledgable in Spring, please check my work :) Is > > > > there a > > > > way to easily populate maps of beans, instead of hard coding the > > > > providers? > > > > > > > > > > > hehe it looks plexus have some nice features ;-) > > > > > > Cheers, > > > > Brett > > > > > > > > -- > > > > Brett Porter > > > > brett@apache.org > > > > http://blogs.exist.com/bporter/ > > > > > > > > > > > > > > -- > > Brett Porter > > brett@apache.org > > http://blogs.exist.com/bporter/ > > > > > -- > Brett Porter > brett@apache.org > http://blogs.exist.com/bporter/ > > ------=_Part_17704_12512981.1210105781266--