continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: refactoring the SCM
Date Fri, 02 May 2008 04:53:04 GMT
me too after cleaning up. Sorry about that, I'll look into it.

- Brett

On 30/04/2008, at 5:52 AM, Olivier Lamy wrote:

> Hi,
> I can't build the branch :
> /local/olamy/open-source/continuum-svn/builder-branch/continuum-core/ 
> src/main/java/org/apache/maven/continuum/core/action/ 
> AddProjectToCheckOutQueueAction.java:[60,16]
> cannot find symbol
> symbol  : class CheckOutTask
> location: class
> org.apache.maven.continuum.core.action.AddProjectToCheckOutQueueAction
>
>
> 2008/4/27 Brett Porter <brett@apache.org>:
>> Hi,
>>
>> I've started to do some refactoring - this is along the way to the  
>> builder
>> separation I mentioned earlier.
>>
>> If you have a moment, please review r 651947. It's on a branch, but  
>> I'd
>> like to regularly merge to trunk if there are no objects to avoid  
>> getting
>> too distant. I have more tests to write for this first.
>>
>> All I've done is pulled the DefaultContinuumScm class out into a  
>> separate
>> module, and decoupled it from the model. It already contained some  
>> logic
>> related to the SCMs (which may actually need to go back into Maven  
>> SCM
>> itself). I pulled the logging and database updates back into the  
>> actions in
>> code (this did result in some duplication, but I can clean that up  
>> later).
>> It also showed that some code was never having its results used,  
>> and also
>> started to expose some exception handling bugs. I stopped wrapping
>> exceptions and results, choosing to use the Maven SCM API natively.
>>
>> Thoughts?
>>
>> Anyone that is knowledgable in Spring, please check my work :) Is  
>> there a
>> way to easily populate maps of beans, instead of hard coding the  
>> providers?
>>
>
> hehe it looks plexus have some nice features ;-)
>
>> Cheers,
>> Brett
>>
>> --
>> Brett Porter
>> brett@apache.org
>> http://blogs.exist.com/bporter/
>>
>>

--
Brett Porter
brett@apache.org
http://blogs.exist.com/bporter/


Mime
View raw message