Mailing-List: contact continuum-dev-help@maven.apache.org; run by ezmlm
Precedence: bulk
Reply-To: continuum-dev@maven.apache.org
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <47023338.2080008@venisse.net>
Date: Tue, 02 Oct 2007 14:02:00 +0200
From: Emmanuel Venisse <emmanuel@venisse.net>
User-Agent: Thunderbird 2.0.0.6 (Windows/20070728)
MIME-Version: 1.0
To: continuum-dev@maven.apache.org
Subject: Re: CONTINUUM-310 - customizable email templates
References: <fc59deef0710010436p1e41dd97u1df37a538f8bb33@mail.gmail.com>
	 <4701A711.8050007@apache.org> <4701EEC1.3070401@venisse.net>
 <fc59deef0710020431h36911fbewcc7f1cc49c13469f@mail.gmail.com>
In-Reply-To: <fc59deef0710020431h36911fbewcc7f1cc49c13469f@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit


Tomislav Stojcevich a �crit :
> I think it should be re-opened since there still is no way to
> completely customize the template itself other than turning on and off
> the output and summary.  In my case the turning on the summary wiith
> the build output turned off will give me what I want but it is still
> too much.  I'd like to be able to customize further, there are only a
> couple of things from the summary that I want to see.  We could
> continue to add flags to the xml file and if checks within the
> template but where does it stop?
> 
> And what about internationalization? that would have to be a separate
> issue but allowing access to be able to modify the templates directly
> would at least let those users that really need to change the language
> of the text that is hardcoded in the template to be able to do it
> should they need to.
> 
> So how about my idea about extracting the templates from the core jar
> into the webapp during the webapp build, that way they can be directly
> modified?  This at least allows the default templates to be
> customizable easily.

I don't think it's the best solution. IMO, it would be better to allow the user to choose the template he want to use if he don't want the default.
> 
> 
> Another issue should be opened to provide the functionality that Rahul
> is suggesting about allowing different templates per group or project.
>  That would involve more changes.  There would have to be a place in
> the database to store template location per project or group or
> possibly store the template itself and provide a template edit screen.

If we allow to have a template per group or project, in fact per mail notifier, it's easy to add this feature if the one above is implemented. We can store it in the mail notifier configuration field 
so we don't need to change the db schema for it.

Emmanuel