continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From leahpar <raphael.pe...@free.fr>
Subject continuum and perforce
Date Wed, 18 Apr 2007 21:07:53 GMT

Hello world,

1-

There's an issue with continuum and perforce with evenisse 512303 : 
class:		ContinuDefaultContinuumScm
method:		private ScmRepository getScmRepository( Project project, boolean
useCredentialsCache )
bad? line:	System.setProperty( "maven.scm.perforce.clientspec.name", null ); 
proposed line:	System.clearProperty(
PerforceScmProvider.DEFAULT_CLIENTSPEC_PROPERTY);
because:	value of Properties cannot be null 

2-
Link to the previous issue, something else should be done here? no?
class:		PerforceScmProvider
method: 	public static String getClientspecName(
PerforceScmProviderRepository repo, File workDir )
bad line:	return System.getProperty( DEFAULT_CLIENTSPEC_PROPERTY,
generateDefaultClientspecName( repo, workDir ) );

Thanks 

-- 
View this message in context: http://www.nabble.com/continuum-and-perforce-tf3603243.html#a10066462
Sent from the Continuum - Dev mailing list archive at Nabble.com.


Mime
View raw message