continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Williams <a...@handyande.co.uk>
Subject Re: svn commit: r515406 - /maven/continuum/trunk/continuum-release/src/main/resources/META-INF/plexus/components.xml
Date Fri, 16 Mar 2007 01:08:09 GMT
You misunderstand it's purpose.
I am not defining a dependency, but rather re-declaring the component.
That is a copy of the "maven" hinted component as "default". The  
latest maven-project uses "default" so this is a temporary measure.

Does that make sense?
Andy

On 15 Mar 2007, at 22:41, Emmanuel Venisse wrote:

> Handy,
>
> I think this patch is wrong, we need to use this component with  
> 'maven' role-hint because it's this component declared in maven- 
> project.
>
> Emmanuel
>
> handyande@apache.org a écrit :
>> Author: handyande
>> Date: Tue Mar  6 17:17:11 2007
>> New Revision: 515406
>> URL: http://svn.apache.org/viewvc?view=rev&rev=515406
>> Log:
>> We need this component declaration for now, as the released  
>> components were on non-default role-hints, but the impl expects a  
>> default, so we provide it.
>> This can be removed once continuum gets a 2.1-SNAP maven dep
>> Modified:
>>     maven/continuum/trunk/continuum-release/src/main/resources/ 
>> META-INF/plexus/components.xml
>> Modified: maven/continuum/trunk/continuum-release/src/main/ 
>> resources/META-INF/plexus/components.xml
>> URL: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum- 
>> release/src/main/resources/META-INF/plexus/components.xml? 
>> view=diff&rev=515406&r1=515405&r2=515406
>> ===================================================================== 
>> =========
>> --- maven/continuum/trunk/continuum-release/src/main/resources/ 
>> META-INF/plexus/components.xml (original)
>> +++ maven/continuum/trunk/continuum-release/src/main/resources/ 
>> META-INF/plexus/components.xml Tue Mar  6 17:17:11 2007
>> @@ -314,6 +314,25 @@
>>        </configuration>
>>      </component>
>>  +    <!-- This needs to be removed once we can upgrade maven- 
>> project to 2.1-SNAPSHOT or later. -->
>> +    <component>
>> +       
>> <role>org.apache.maven.artifact.metadata.ArtifactMetadataSource</ 
>> role>
>> +      <role-hint>default</role-hint>
>> +       
>> <implementation>org.apache.maven.project.artifact.MavenMetadataSource 
>> </implementation>
>> +      <requirements>
>> +        <requirement>
>> +          <role>org.apache.maven.project.MavenProjectBuilder</role>
>> +        </requirement>
>> +        <requirement>
>> +           
>> <role>org.apache.maven.artifact.factory.ArtifactFactory</role>
>> +        </requirement>
>> +        <requirement>
>> +           
>> <role>org.apache.maven.artifact.repository.metadata.RepositoryMetadat 
>> aManager</role
>> +>
>> +        </requirement>
>> +      </requirements>
>> +    </component>
>> +
>>    </components>
>>   </component-set>
>


Mime
View raw message