continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jesse McConnell" <jesse.mcconn...@gmail.com>
Subject Re: svn commit: r490000 - in /maven/continuum/branches/key-based-refactor/continuum-store/src/test/java/org/apache/maven/continuum/store: AbstractContinuumStoreTestCase.java ContinuumStoreTest.java
Date Tue, 26 Dec 2006 13:50:31 GMT
On 12/24/06, rinku@apache.org <rinku@apache.org> wrote:
> Author: rinku
> Date: Sun Dec 24 00:12:41 2006
> New Revision: 490000
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=490000
> Log:
> o  updates to store unit tests for refactorings.
>
> Modified:

> @@ -896,7 +902,9 @@
>      {
>          try
>          {
> -            store.getProject( project.getId() );
> +            // TODO: Review! Since the Project key is unique only within a group
> +            // shouldn't we specify the Group Key as well for deletion.
> +            store.getProject( new GroupProjectKey(null, project.getKey() ) );
>              fail( "Project should no longer exist" );
>          }
>          catch ( ContinuumObjectNotFoundException expected )
>
>
>

yes, most definitely we need to make sure these checks pull the group
key into context, otherwise we'll end up with arrays of results
instead of a particular unique project.  I was just looking for
instances of this when I saw your comment so happy we both had it in
mind.

jesse


-- 
jesse mcconnell
jesse.mcconnell@gmail.com

Mime
View raw message