Return-Path: Delivered-To: apmail-maven-continuum-dev-archive@www.apache.org Received: (qmail 25767 invoked from network); 30 Oct 2006 16:15:34 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 30 Oct 2006 16:15:34 -0000 Received: (qmail 71551 invoked by uid 500); 30 Oct 2006 16:15:45 -0000 Delivered-To: apmail-maven-continuum-dev-archive@maven.apache.org Received: (qmail 71531 invoked by uid 500); 30 Oct 2006 16:15:45 -0000 Mailing-List: contact continuum-dev-help@maven.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: continuum-dev@maven.apache.org Delivered-To: mailing list continuum-dev@maven.apache.org Received: (qmail 71520 invoked by uid 99); 30 Oct 2006 16:15:45 -0000 Received: from herse.apache.org (HELO herse.apache.org) (140.211.11.133) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Oct 2006 08:15:45 -0800 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received-SPF: pass (herse.apache.org: local policy) Received: from [80.175.38.168] (HELO rectang.com) (80.175.38.168) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 30 Oct 2006 08:15:30 -0800 Received: from [129.215.71.143] (dlib-grog.ucs.ed.ac.uk [129.215.71.143]) by rectang.com (Postfix) with ESMTP id C9429182FB for ; Mon, 30 Oct 2006 16:15:10 +0000 (GMT) Message-ID: <4546253C.7000701@handyande.co.uk> Date: Mon, 30 Oct 2006 16:15:56 +0000 From: Andrew Williams User-Agent: Thunderbird 1.5.0.7 (X11/20060918) MIME-Version: 1.0 To: continuum-dev@maven.apache.org Subject: Re: [discuss] Writing WebWork actions References: <000901c6f869$4dfa6d70$4001a8c0@nonec03d6244ff> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org I personally agree with the one class for CRUD. The reason I have for this is that if you use ModelDriven and the Verifiable (Or whatever - I forget the exact names) it saves much duplication of time. Readability and testing I have found easier under this approach too. Also it is worth noting that there are no unused fields with ModelDriven - everything is accessed through the one model class. Just my tuppence worth A Jesse McConnell wrote: > I also bounced this off of a couple other people over the last day or > to.. > > there seems to be a general consensus from folks that I talked to that > its a good idea to try and group all the CRUD (Create, Read, Update, > Delete) actions on objects grouped into a single action. > > On that note, it would be good to standardize the method names as > well, perhaps to: > > public String add() {} > public String update() {} > public String view() {} > public String remove() {} > > Then we would have the decision of the xwork.xml which could have > actions for each of these methods on the class, like > > > > or on the jsp's we could just use the shortcut of action="foo!add"> > > how does this grab folks? I think this is a valuable step in things > since it will give us a chance to audit all of the actions, improve > the -webapp project for contributors...and -webapp is a great place > for people to start with continuum...and it will also serve as a good > swift kick towards finishing off the testing work that emmanuel will > be committing soon. > > jesse > >