continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r443226 - in /maven/continuum/branches/release-integration/continuum: continuum-api/src/main/java/org/apache/maven/continuum/release/ continuum-release/src/main/java/org/apache/maven/continuum/release/ continuum-release/src/main/java/org/ap...
Date Tue, 19 Sep 2006 04:22:29 GMT

On 14/09/2006, at 2:31 PM, epunzalan@apache.org wrote:

> Modified: maven/continuum/branches/release-integration/continuum/ 
> continuum-release/src/main/java/org/apache/maven/continuum/release/ 
> DefaultContinuumReleaseManager.java
> URL: http://svn.apache.org/viewvc/maven/continuum/branches/release- 
> integration/continuum/continuum-release/src/main/java/org/apache/ 
> maven/continuum/release/DefaultContinuumReleaseManager.java? 
> view=diff&rev=443226&r1=443225&r2=443226
> ====================================================================== 
> ========
> --- maven/continuum/branches/release-integration/continuum/ 
> continuum-release/src/main/java/org/apache/maven/continuum/release/ 
> DefaultContinuumReleaseManager.java (original)
> +++ maven/continuum/branches/release-integration/continuum/ 
> continuum-release/src/main/java/org/apache/maven/continuum/release/ 
> DefaultContinuumReleaseManager.java Wed Sep 13 21:31:48 2006
> @@ -58,6 +58,12 @@
>       */
>      private static Map preparedReleases;
>
> +    /**
> +     * contains results
> +     * @todo remove static when singleton strategy is working
> +     */
> +    private static Map releaseResults;
> +
>      public String prepare( Project project, Properties  
> releaseProperties, Map relVersions,
>                             Map devVersions,  
> ContinuumReleaseManagerListener listener )
>          throws ContinuumReleaseException
> @@ -142,9 +148,14 @@
>          return preparedReleases;
>      }
>
> -    public void setPreparedReleases( Map preparedReleases )
> +    public Map getReleaseResults()
>      {
> -        this.preparedReleases = preparedReleases;
> +        if ( releaseResults == null )
> +        {
> +            releaseResults = new Hashtable();
> +        }
> +
> +        return releaseResults;
>      }

Maybe I'm misunderstanding, but are release results really a  
singleton? I thought they were specific to an execution of the release.

- Brett

Mime
View raw message