continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r442602 - in /maven/continuum/branches/release-integration/continuum: continuum-release/src/main/java/org/apache/maven/continuum/release/ continuum-release/src/main/java/org/apache/maven/continuum/release/executors/ continuum-webapp/src/mai...
Date Tue, 19 Sep 2006 04:19:41 GMT

On 13/09/2006, at 12:55 AM, epunzalan@apache.org wrote:

>
>      /**
>       * contains previous release:prepare descriptors; one per project
> +     * @todo remove static when singleton strategy is working
>       */
> -    private Map preparedReleases;
> +    private static Map preparedReleases;

What wasn't working?

>
> +            <ww:iterator value="listener.phases">
> +              <tr>
> +                <ww:if test="listener.completedPhases.contains 
> ( top )">
> +                  <td>done</td>
> +                </ww:if>
> +                <ww:elseif test="listener.inProgress.equals( top )">
> +                  <ww:if test="listener.error == null">
> +                    <td>in progress</td>
> +                  </ww:if>
> +                  <ww:else>
> +                    <td>error</td>
> +                  </ww:else>
> +                </ww:elseif>
> +                <ww:else>
> +                  <td>not done</td>
> +                </ww:else>
> +                <td><ww:property/></td>
> +              </tr>
> +            </ww:iterator>

Can we use the icons here instead of text?

> +          <select name="preparedReleaseId">
>              <ww:if test="preparedReleaseName != null">
> -              <option selected value="<ww:property  
> value="preparedReleaseName"/>">
> +              <option selected value="<ww:property  
> value="preparedReleaseId"/>">
>                  <ww:property value="preparedReleaseName"/>
>                </option>
>              </ww:if>
> -            <option value="none">Provide release descriptor</option>
> +            <option value="">Provide release descriptor</option>
>            </select>

why not ww:select?

- Brett


Mime
View raw message