continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brett Porter <br...@apache.org>
Subject Re: svn commit: r431764 - /maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp
Date Wed, 16 Aug 2006 02:13:14 GMT
Since it's an action URL, I strong suggest using ww:url instead.

- Brett

On 16/08/2006 12:04 PM, Carlos Sanchez wrote:
> i've seen this problem with tomcat. Works fine with jetty.
> 
> Please add a jira to put back the right url composition, your changes
> won't work in some cases (we just moved all url composition to use
> c:url)
> 
> On 8/15/06, Brett Porter <brett@apache.org> wrote:
>> There are two versions of c: - core, and core_rt. If you are including a
>> TLD in the webapp, make sure you have the right one.
>>
>> I usually just omit the tlds in the webapp and use:
>> <%@ taglib prefix="c" uri="http://java.sun.com/jsp/jstl/core" %>
>> (note this is JSTL 1.1, the URL is different for JSTL 1.0, which might
>> also be the problem).
>>
>> This gets pulled from the JAR. Seems to work just fine in MRM.
>>
>> - Brett
>>
>> On 16/08/2006 11:41 AM, kenney@apache.org wrote:
>> > Author: kenney
>> > Date: Tue Aug 15 18:41:17 2006
>> > New Revision: 431764
>> >
>> > URL: http://svn.apache.org/viewvc?rev=431764&view=rev
>> > Log:
>> > Use <c:url because of the url completion, but not c:param (for now).
>> >
>> > <c:*> tags don't evaluate the expressions, somehow. Not sure why 
>> this doesn't
>> > work..
>> >
>> > This problem also exists in schedules.jsp (and probably other places).
>> >
>> > Added a workaround for the main page for now.
>> >
>> > Modified:
>> >     maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp
>> >
>> > Modified: 
>> maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp
>> > URL: 
>> http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp?rev=431764&r1=431763&r2=431764&view=diff

>>
>> > 
>> ============================================================================== 
>>
>> > --- 
>> maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp 
>> (original)
>> > +++ 
>> maven/continuum/trunk/continuum-webapp/src/main/webapp/summary.jsp Tue 
>> Aug 15 18:41:17 2006
>> > @@ -19,13 +19,8 @@
>> >            <ec:row highlightRow="true">
>> >              <ec:column property="state" title="&nbsp;" width="1%" 
>> cell="org.apache.maven.continuum.web.view.StateCell"/>
>> >              <ec:column property="name" 
>> title="summary.projectTable.name" width="48%">
>> > -                <!--this doesn't work as the project.id isn't 
>> interpolated
>> > -                <c:url var="projectViewUrl" 
>> value="/projectView.action">
>> > -                  <c:param name="projectId" value="${project.id}"/>
>> > -                </c:url>
>> > -                <a href="<c:out 
>> value='${projectViewUrl}'/>">${project.name}</a>
>> > -                -->
>> > -                <a 
>> href="/projectView.action?projectId=${project.id}">${project.name}</a>
>> > +                <c:url var="projectViewUrl" 
>> value="/projectView.action"/>
>> > +                <a href="<c:out 
>> value='${projectViewUrl}?projectId=${project.id}'/>">${project.name}</a>
>> >              </ec:column>
>> >              <ec:column property="version" 
>> title="summary.projectTable.version" width="13%"/>
>> >              <ec:column property="buildNumber" 
>> title="summary.projectTable.build" width="5%" 
>> cell="org.apache.maven.continuum.web.view.BuildCell"/>
>> >
>> >
>>
>>
>> -- 
>> Apache Maven - http://maven.apache.org/
>> Better Builds with Maven - http://library.mergere.com/
>>
> 
> 


-- 
Apache Maven - http://maven.apache.org/
Better Builds with Maven - http://library.mergere.com/

Mime
View raw message