continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Ewins (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (CONTINUUM-413) build reported as successful on win xp even when maven 1 build fails
Date Fri, 04 Nov 2005 15:47:07 GMT
    [ http://jira.codehaus.org/browse/CONTINUUM-413?page=comments#action_50047 ] 

Brian Ewins commented on CONTINUUM-413:
---------------------------------------

The FAQ answer is incorrect.

The suggestion of setting MAVEN_TERMINATE_CMD to "on" in the environment makes the code do
this every time:
exit %ERROR_CODE% 
except that ERROR_CODE isn't defined - should have been ERRORLEVEL. Even if it was, this causes
exit to be called every time, and without a /B flag that kills off the command window, which
is a bit useless outside continuum. 

The correct answer is, change continuum's run.bat to begin:
@echo off
set MAVEN_TERMINATE_CMD=on

then add this one line to the end of maven.bat:
if "%MAVEN_TERMINATE_CMD%" == "on" exit %ERRORLEVEL% 

I've tested this solution, it works.

> build reported as successful on win xp even when maven 1 build fails
> --------------------------------------------------------------------
>
>          Key: CONTINUUM-413
>          URL: http://jira.codehaus.org/browse/CONTINUUM-413
>      Project: Continuum
>         Type: Bug
>     Versions: 1.0
>  Environment: Maven 1.0.2
> Java 1.5
> Win XP SP2
> Continuum 1.0
>     Reporter: Zach B
>     Assignee: Emmanuel Venisse
>      Fix For: 1.0.1

>
>
> Continuum always reports a successful build even when Maven reports a build failure.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message