continuum-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Brian Ewins (JIRA)" <j...@codehaus.org>
Subject [jira] Commented: (CONTINUUM-413) build reported as successful on win xp even when maven 1 build fails
Date Fri, 04 Nov 2005 18:40:06 GMT
    [ http://jira.codehaus.org/browse/CONTINUUM-413?page=comments#action_50061 ] 

Brian Ewins commented on CONTINUUM-413:
---------------------------------------

Ok, I did more checking (since I did believe you tested this!). This bug was reported against
the current /stable/ version of maven1, ie maven 1.0.2. That has maven.bat from immediately
prior to this change:
http://svn.apache.org/viewcvs.cgi/maven/maven-1/core/trunk/src/bin/maven.bat?rev=165456&r1=122478&r2=165456
I downloaded a fresh copy of 1.0.2 to make sure I hadn't messed mine up.

This patch added ERROR_CODE as a synonym, as you say. However, I still don't think the FAQ
is right. On the bleeding edge of maven1, the code to exit on error is already there, and
all that is needed is for continuum to set MAVEN_TERMINATE_CMD, ie the change to run.bat I
described above. For maven 1.0.2, support for using ERROR_CODE isn't there and the change
in the FAQ isn't enough.

However, from reading up on this, theres a caveat: my change to maven.bat will only work on
winXP, win2k3. Documentation on the corresponding ant bug:
http://issues.apache.org/bugzilla/show_bug.cgi?id=13655
shows that the solution needs to be different on win95, NT - incorporating all the changes
that are now in maven-1 HEAD.

> build reported as successful on win xp even when maven 1 build fails
> --------------------------------------------------------------------
>
>          Key: CONTINUUM-413
>          URL: http://jira.codehaus.org/browse/CONTINUUM-413
>      Project: Continuum
>         Type: Bug
>     Versions: 1.0
>  Environment: Maven 1.0.2
> Java 1.5
> Win XP SP2
> Continuum 1.0
>     Reporter: Zach B
>     Assignee: Emmanuel Venisse
>      Fix For: 1.0.1

>
>
> Continuum always reports a successful build even when Maven reports a build failure.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


Mime
View raw message