continuum-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbac...@apache.org
Subject svn commit: r1140475 - /continuum/trunk/continuum-core/src/main/java/org/apache/continuum/buildmanager/ParallelBuildsManager.java
Date Tue, 28 Jun 2011 08:17:56 GMT
Author: mbaclay
Date: Tue Jun 28 08:17:55 2011
New Revision: 1140475

URL: http://svn.apache.org/viewvc?rev=1140475&view=rev
Log:
[CONTINUUM-2346] NPE in log on forced build and project never builds
Improvised error description so that an informative message can be displayed to user
Submitted by: Gwen Harold Autencio


Modified:
    continuum/trunk/continuum-core/src/main/java/org/apache/continuum/buildmanager/ParallelBuildsManager.java

Modified: continuum/trunk/continuum-core/src/main/java/org/apache/continuum/buildmanager/ParallelBuildsManager.java
URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-core/src/main/java/org/apache/continuum/buildmanager/ParallelBuildsManager.java?rev=1140475&r1=1140474&r2=1140475&view=diff
==============================================================================
--- continuum/trunk/continuum-core/src/main/java/org/apache/continuum/buildmanager/ParallelBuildsManager.java
(original)
+++ continuum/trunk/continuum-core/src/main/java/org/apache/continuum/buildmanager/ParallelBuildsManager.java
Tue Jun 28 08:17:55 2011
@@ -186,6 +186,14 @@ public class ParallelBuildsManager
         if ( firstProjectId != 0 )
         {
             BuildDefinition buildDef = projectsBuildDefinitionsMap.get( firstProjectId );
+            
+            if ( buildDef.getArguments() == null || buildDef.getBuildFile() == null || buildDef.getGoals()
== null || buildDef.getSchedule() == null )
+            {
+                log.error( "Null values set on build definition (id=" + buildDef.getId()
+ ")" );
+                throw new BuildManagerException( "Unable to build project due to null values
set on " +
+                                                 "( GOALS , ARGUMENTS , BUILD_FILE, SCHEDULE_ID_OID
) of BUILDDEFINITION ID : " 
+                                                 + buildDef.getId() + " Please notify your
system adminitrator");
+            }
             OverallBuildQueue overallBuildQueue = getOverallBuildQueueWhereProjectsInGroupAreQueued(
projectGroupId );
 
             if ( overallBuildQueue == null )



Mime
View raw message