Return-Path: Delivered-To: apmail-continuum-commits-archive@www.apache.org Received: (qmail 59543 invoked from network); 30 Mar 2010 12:07:24 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 30 Mar 2010 12:07:24 -0000 Received: (qmail 83197 invoked by uid 500); 30 Mar 2010 12:07:24 -0000 Delivered-To: apmail-continuum-commits-archive@continuum.apache.org Received: (qmail 83137 invoked by uid 500); 30 Mar 2010 12:07:24 -0000 Mailing-List: contact commits-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list commits@continuum.apache.org Received: (qmail 83130 invoked by uid 99); 30 Mar 2010 12:07:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Mar 2010 12:07:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Mar 2010 12:07:21 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 8FBFE2388994; Tue, 30 Mar 2010 12:07:00 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r929101 - /continuum/trunk/continuum-core/src/main/java/org/apache/continuum/builder/distributed/manager/DefaultDistributedBuildManager.java Date: Tue, 30 Mar 2010 12:07:00 -0000 To: commits@continuum.apache.org From: ctan@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20100330120700.8FBFE2388994@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ctan Date: Tue Mar 30 12:07:00 2010 New Revision: 929101 URL: http://svn.apache.org/viewvc?rev=929101&view=rev Log: eliminate multiple calls to method Modified: continuum/trunk/continuum-core/src/main/java/org/apache/continuum/builder/distributed/manager/DefaultDistributedBuildManager.java Modified: continuum/trunk/continuum-core/src/main/java/org/apache/continuum/builder/distributed/manager/DefaultDistributedBuildManager.java URL: http://svn.apache.org/viewvc/continuum/trunk/continuum-core/src/main/java/org/apache/continuum/builder/distributed/manager/DefaultDistributedBuildManager.java?rev=929101&r1=929100&r2=929101&view=diff ============================================================================== --- continuum/trunk/continuum-core/src/main/java/org/apache/continuum/builder/distributed/manager/DefaultDistributedBuildManager.java (original) +++ continuum/trunk/continuum-core/src/main/java/org/apache/continuum/builder/distributed/manager/DefaultDistributedBuildManager.java Tue Mar 30 12:07:00 2010 @@ -1202,15 +1202,19 @@ public class DefaultDistributedBuildMana private boolean hasBuildagentGroup( Map projectsAndBuildDefinitionsMap ) throws ContinuumException { - return getBuildAgentGroup( projectsAndBuildDefinitionsMap ) != null && - getBuildAgentGroup( projectsAndBuildDefinitionsMap ).getName().length() > 0 ? true : false; + BuildAgentGroupConfiguration buildAgentGroup = getBuildAgentGroup( projectsAndBuildDefinitionsMap ); + + return buildAgentGroup != null && + buildAgentGroup.getName().length() > 0 ? true : false; } private boolean hasBuildagentInGroup( Map projectsAndBuildDefinitionsMap ) throws ContinuumException { - return getBuildAgentGroup( projectsAndBuildDefinitionsMap ).getBuildAgents() != null && - getBuildAgentGroup( projectsAndBuildDefinitionsMap ).getBuildAgents().size() > 0 ? true : false; + BuildAgentGroupConfiguration buildAgentGroup = getBuildAgentGroup( projectsAndBuildDefinitionsMap ); + + return buildAgentGroup != null && + buildAgentGroup.getBuildAgents().size() > 0 ? true : false; } // for unit testing