From commits-return-5653-apmail-continuum-commits-archive=continuum.apache.org@continuum.apache.org Mon Aug 03 23:08:42 2009 Return-Path: Delivered-To: apmail-continuum-commits-archive@www.apache.org Received: (qmail 68963 invoked from network); 3 Aug 2009 23:08:42 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 3 Aug 2009 23:08:42 -0000 Received: (qmail 53933 invoked by uid 500); 3 Aug 2009 23:08:47 -0000 Delivered-To: apmail-continuum-commits-archive@continuum.apache.org Received: (qmail 53871 invoked by uid 500); 3 Aug 2009 23:08:47 -0000 Mailing-List: contact commits-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list commits@continuum.apache.org Received: (qmail 53862 invoked by uid 99); 3 Aug 2009 23:08:43 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2009 23:08:43 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 03 Aug 2009 23:08:34 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id EC2A12388891; Mon, 3 Aug 2009 23:08:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r800611 - /continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/project/builder/AbstractContinuumProjectBuilder.java Date: Mon, 03 Aug 2009 23:08:12 -0000 To: commits@continuum.apache.org From: ctan@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20090803230812.EC2A12388891@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Author: ctan Date: Mon Aug 3 23:08:12 2009 New Revision: 800611 URL: http://svn.apache.org/viewvc?rev=800611&view=rev Log: [CONTINUUM-2314] hide password in url when adding project fails Modified: continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/project/builder/AbstractContinuumProjectBuilder.java Modified: continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/project/builder/AbstractContinuumProjectBuilder.java URL: http://svn.apache.org/viewvc/continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/project/builder/AbstractContinuumProjectBuilder.java?rev=800611&r1=800610&r2=800611&view=diff ============================================================================== --- continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/project/builder/AbstractContinuumProjectBuilder.java (original) +++ continuum/branches/continuum-1.3.x/continuum-core/src/main/java/org/apache/maven/continuum/project/builder/AbstractContinuumProjectBuilder.java Mon Aug 3 23:08:12 2009 @@ -232,38 +232,40 @@ protected File createMetadataFile( ContinuumProjectBuildingResult result, URL metadata, String username, String password ) { + String url = metadata.toExternalForm(); + try { return createMetadataFile( metadata, username, password, result ); } catch ( FileNotFoundException e ) { - log.info( "URL not found: " + metadata, e ); + log.info( "URL not found: " + hidePasswordInUrl( url ), e ); result.addError( ContinuumProjectBuildingResult.ERROR_POM_NOT_FOUND ); } catch ( MalformedURLException e ) { - log.info( "Malformed URL: " + metadata, e ); + log.info( "Malformed URL: " + hidePasswordInUrl( url ), e ); result.addError( ContinuumProjectBuildingResult.ERROR_MALFORMED_URL ); } catch ( URISyntaxException e ) { - log.info( "Malformed URL: " + metadata, e ); + log.info( "Malformed URL: " + hidePasswordInUrl( url ), e ); result.addError( ContinuumProjectBuildingResult.ERROR_MALFORMED_URL ); } catch ( UnknownHostException e ) { - log.info( "Unknown host: " + metadata, e ); + log.info( "Unknown host: " + hidePasswordInUrl( url ), e ); result.addError( ContinuumProjectBuildingResult.ERROR_UNKNOWN_HOST ); } catch ( IOException e ) { - log.warn( "Could not download the URL: " + metadata, e ); + log.warn( "Could not download the URL: " + hidePasswordInUrl( url ), e ); result.addError( ContinuumProjectBuildingResult.ERROR_UNKNOWN ); } catch ( HttpException e ) { - log.warn( "Could not download the URL: " + metadata, e ); + log.warn( "Could not download the URL: " + hidePasswordInUrl( url ), e ); result.addError( ContinuumProjectBuildingResult.ERROR_UNKNOWN ); } return null;