continuum-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From och...@apache.org
Subject svn commit: r774693 - in /continuum/branches/continuum-flat-multi-module: continuum-core/src/main/java/org/apache/maven/continuum/ continuum-core/src/main/java/org/apache/maven/continuum/core/action/ continuum-webapp/src/main/java/org/apache/maven/cont...
Date Thu, 14 May 2009 08:48:44 GMT
Author: oching
Date: Thu May 14 08:48:44 2009
New Revision: 774693

URL: http://svn.apache.org/viewvc?rev=774693&view=rev
Log:
cleanup comments

Modified:
    continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
    continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/core/action/UpdateWorkingDirectoryFromScmContinuumAction.java
    continuum/branches/continuum-flat-multi-module/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleaseRollbackAction.java

Modified: continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
URL: http://svn.apache.org/viewvc/continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java?rev=774693&r1=774692&r2=774693&view=diff
==============================================================================
--- continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
(original)
+++ continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/DefaultContinuum.java
Thu May 14 08:48:44 2009
@@ -986,8 +986,6 @@
         Map<Integer, Integer> projectsBuildDefinitionsMap = new HashMap<Integer,
Integer>();
         projectsBuildDefinitionsMap.put( projectId, buildDef.getId() );
 
-        // TODO: deng - projects under the same root project should be queued in the same
checkout & build queue!
-        //   - not sure where this should be fixed
         ProjectScmRoot scmRoot = getProjectScmRootByProject( projectId );
         prepareBuildProjects( projectsBuildDefinitionsMap, trigger, scmRoot.getScmRootAddress(),
                               scmRoot.getProjectGroup().getId(), scmRoot.getId() );

Modified: continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/core/action/UpdateWorkingDirectoryFromScmContinuumAction.java
URL: http://svn.apache.org/viewvc/continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/core/action/UpdateWorkingDirectoryFromScmContinuumAction.java?rev=774693&r1=774692&r2=774693&view=diff
==============================================================================
--- continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/core/action/UpdateWorkingDirectoryFromScmContinuumAction.java
(original)
+++ continuum/branches/continuum-flat-multi-module/continuum-core/src/main/java/org/apache/maven/continuum/core/action/UpdateWorkingDirectoryFromScmContinuumAction.java
Thu May 14 08:48:44 2009
@@ -102,10 +102,6 @@
         catch ( Exception e )
         {
         }
-
-        // TODO: deng - should the update be from the scm root url? if so, then it seems
that not all the projects within
-        //      the same scm root should update! maybe only the root project? OR all projects
sharing the same scm 
-        //      root must update from the scm root! (second option is more sensible)
         
         try
         {

Modified: continuum/branches/continuum-flat-multi-module/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleaseRollbackAction.java
URL: http://svn.apache.org/viewvc/continuum/branches/continuum-flat-multi-module/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleaseRollbackAction.java?rev=774693&r1=774692&r2=774693&view=diff
==============================================================================
--- continuum/branches/continuum-flat-multi-module/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleaseRollbackAction.java
(original)
+++ continuum/branches/continuum-flat-multi-module/continuum-webapp/src/main/java/org/apache/maven/continuum/web/action/ReleaseRollbackAction.java
Thu May 14 08:48:44 2009
@@ -92,9 +92,7 @@
             ContinuumReleaseManagerListener listener = new DefaultReleaseManagerListener();
     
             Project project = getContinuum().getProject( projectId );
-    
-            // TODO: deng - this also needs to be updated! the workingDirectoryService called
should be
-            //      the one with the 3 params
+            
             releaseManager.rollback( releaseId, workingDirectoryService.getWorkingDirectory(
project ).getPath(), listener );
     
             //recurse until rollback is finished



Mime
View raw message