From commits-return-4442-apmail-continuum-commits-archive=continuum.apache.org@continuum.apache.org Thu Oct 23 05:06:21 2008 Return-Path: Delivered-To: apmail-continuum-commits-archive@www.apache.org Received: (qmail 74941 invoked from network); 23 Oct 2008 05:06:21 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 23 Oct 2008 05:06:21 -0000 Received: (qmail 78258 invoked by uid 500); 23 Oct 2008 05:06:24 -0000 Delivered-To: apmail-continuum-commits-archive@continuum.apache.org Received: (qmail 78234 invoked by uid 500); 23 Oct 2008 05:06:24 -0000 Mailing-List: contact commits-help@continuum.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@continuum.apache.org Delivered-To: mailing list commits@continuum.apache.org Received: (qmail 78225 invoked by uid 99); 23 Oct 2008 05:06:24 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 22 Oct 2008 22:06:24 -0700 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.4] (HELO eris.apache.org) (140.211.11.4) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Oct 2008 05:05:12 +0000 Received: by eris.apache.org (Postfix, from userid 65534) id 2866023889C1; Wed, 22 Oct 2008 22:05:51 -0700 (PDT) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: svn commit: r707273 [4/7] - in /continuum/branches/continuum-struts2: ./ continuum-core/ continuum-core/src/test/resources/ continuum-webapp/ continuum-webapp/src/main/java/org/apache/continuum/web/action/ continuum-webapp/src/main/java/org/apache/cont... Date: Thu, 23 Oct 2008 05:05:43 -0000 To: commits@continuum.apache.org From: evenisse@apache.org X-Mailer: svnmailer-1.0.8 Message-Id: <20081023050551.2866023889C1@eris.apache.org> X-Virus-Checked: Checked by ClamAV on apache.org Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildDefinitionEdit.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildDefinitionEdit.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildDefinitionEdit.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildDefinitionEdit.jsp Wed Oct 22 22:05:36 2008 @@ -17,26 +17,26 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri='http://java.sun.com/jsp/jstl/core' prefix='c'%> <%@ taglib uri="continuum" prefix="c1" %> - + - <ww:text name="buildDefinition.page.title"/> + <s:text name="buildDefinition.page.title"/>
-

+

- +
-

+

@@ -45,58 +45,58 @@ - - - - - - - - - + + + + + + + + + - - - - - - - - + + + + + + + + - - - - - - - - - - - + + + + + + + + + + - - + +
- - - - - - - + + + + + + +
-
+
-
+ Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildResult.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildResult.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildResult.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildResult.jsp Wed Oct 22 22:05:36 2008 @@ -17,15 +17,15 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri="http://www.extremecomponents.org" prefix="ec" %> <%@ taglib uri='http://java.sun.com/jsp/jstl/core' prefix='c'%> <%@ taglib prefix="c1" uri="continuum" %> <%@ taglib uri="http://plexus.codehaus.org/redback/taglib-1.0" prefix="redback" %> - + - <ww:text name="buildResult.page.title"/> + <s:text name="buildResult.page.title"/>
@@ -33,38 +33,38 @@

- - - + + +

- + - + - - + + - + - + - - - - - + + + + +   - - + +
@@ -75,14 +75,14 @@
- "/> - "/> - - "/> - - - "/> - + "/> + "/> + + "/> + + + "/> +
@@ -91,9 +91,9 @@
-

- - +

+ + -
- - - - - -

- + + + + + + +

+ -
+ -

- - +

+ + -
- - - + + + + -

+

- + - - + + - - + + - - + + - - + + - - + + - + - - + + - - + + - - + + - - + + - - + + - - + + - + - - + + - + - - + +
- -

+ +

- - - - - - -
+ + + + + + + - -

+ +

-
+
-
- -

+ + +

- - - - - - - - - + + + + + + + + +

-
+
-
+

- + -
+ Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildResults.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildResults.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildResults.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/buildResults.jsp Wed Oct 22 22:05:36 2008 @@ -17,14 +17,14 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri="http://www.extremecomponents.org" prefix="ec" %> <%@ taglib uri='http://java.sun.com/jsp/jstl/core' prefix='c'%> <%@ taglib uri="http://plexus.codehaus.org/redback/taglib-1.0" prefix="redback" %> - + - <ww:text name="buildResults.page.title"/> + <s:text name="buildResults.page.title"/> @@ -35,14 +35,14 @@

- - - + + +

- - - + + + - : ${buildResult.durationTime} + : ${buildResult.durationTime} - : ${buildResult.elapsedTime} + : ${buildResult.elapsedTime} - - - - - - - + + + + + + + - +
- " onclick="document.forms.buildResultsForm.submit();" /> + " onclick="document.forms.buildResultsForm.submit();" />
-
+ -
+ Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/buildDefinitionGroupSummaryComponent.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/buildDefinitionGroupSummaryComponent.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/buildDefinitionGroupSummaryComponent.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/buildDefinitionGroupSummaryComponent.jsp Wed Oct 22 22:05:36 2008 @@ -17,16 +17,16 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri="http://www.extremecomponents.org" prefix="ec" %> <%@ taglib uri='http://java.sun.com/jsp/jstl/core' prefix='c'%> <%@ taglib uri="continuum" prefix="c1" %> <%@ taglib uri="http://plexus.codehaus.org/redback/taglib-1.0" prefix="redback" %> - + -

${projectGroup.name}

- +

${projectGroup.name}

+ - - ${pageScope.buildDefinitionSummary.scheduleId} - - ${pageScope.buildDefinitionSummary.scheduleName} + + ${pageScope.buildDefinitionSummary.scheduleId} + + ${pageScope.buildDefinitionSummary.scheduleName} ${pageScope.buildDefinitionSummary.scheduleName} - - ${pageScope.buildDefinitionSummary.profileId} - - ${pageScope.buildDefinitionSummary.profileName} + + ${pageScope.buildDefinitionSummary.profileId} + + ${pageScope.buildDefinitionSummary.profileName} @@ -63,67 +63,67 @@ - - ${pageScope.buildDefinitionSummary.projectGroupId} - ${pageScope.buildDefinitionSummary.id} - - " alt="" title="" border="0"> + + ${pageScope.buildDefinitionSummary.projectGroupId} + ${pageScope.buildDefinitionSummary.id} + + " alt="" title="" border="0"> - " alt="" title="" border="0" /> + " alt="" title="" border="0" />
- - ${pageScope.buildDefinitionSummary.projectGroupId} - ${pageScope.buildDefinitionSummary.id} - - - " alt="" title="" border="0"> - + + ${pageScope.buildDefinitionSummary.projectGroupId} + ${pageScope.buildDefinitionSummary.id} + + + " alt="" title="" border="0"> + - " alt="" title="" border="0"> + " alt="" title="" border="0">
- - " alt="" title="" border="0"> - - - - ${pageScope.buildDefinitionSummary.projectGroupId} - ${pageScope.buildDefinitionSummary.id} - - - - " alt="" title="" border="0"> - - + + " alt="" title="" border="0"> + + + + ${pageScope.buildDefinitionSummary.projectGroupId} + ${pageScope.buildDefinitionSummary.id} + + + + " alt="" title="" border="0"> + + - " alt="" title="" border="0"> + " alt="" title="" border="0">
-
+
- - "/> - - + + "/> + +
- +

Project Build Definitions

- - - - ${pageScope.buildDefinitionSummary.projectName} + + + + ${pageScope.buildDefinitionSummary.projectName} - - ${pageScope.buildDefinitionSummary.scheduleId} - - ${pageScope.buildDefinitionSummary.scheduleName} + + ${pageScope.buildDefinitionSummary.scheduleId} + + ${pageScope.buildDefinitionSummary.scheduleName} ${pageScope.buildDefinitionSummary.scheduleName} - - ${pageScope.buildDefinitionSummary.profileId} - - ${pageScope.buildDefinitionSummary.profileName} + + ${pageScope.buildDefinitionSummary.profileId} + + ${pageScope.buildDefinitionSummary.profileName} @@ -168,50 +168,50 @@ - - ${pageScope.buildDefinitionSummary.projectId} - ${pageScope.buildDefinitionSummary.id} - - - " alt="" title="" border="0"> - + + ${pageScope.buildDefinitionSummary.projectId} + ${pageScope.buildDefinitionSummary.id} + + + " alt="" title="" border="0"> + - " alt="" title="" border="0" /> + " alt="" title="" border="0" /> - - ${pageScope.buildDefinitionSummary.projectId} - ${pageScope.buildDefinitionSummary.id} - - - " alt="" title="" border="0"> - + + ${pageScope.buildDefinitionSummary.projectId} + ${pageScope.buildDefinitionSummary.id} + + + " alt="" title="" border="0"> + - " alt="" title="" border="0"> + " alt="" title="" border="0"> - - ${pageScope.buildDefinitionSummary.projectId} - ${pageScope.buildDefinitionSummary.id} - - - - " alt="" title="" border="0"> - + + ${pageScope.buildDefinitionSummary.projectId} + ${pageScope.buildDefinitionSummary.id} + + + + " alt="" title="" border="0"> + - " alt="" title="" border="0"> + " alt="" title="" border="0"> -
+ -
+ Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/buildDefinitionSummaryComponent.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/buildDefinitionSummaryComponent.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/buildDefinitionSummaryComponent.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/buildDefinitionSummaryComponent.jsp Wed Oct 22 22:05:36 2008 @@ -17,13 +17,13 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri="http://www.extremecomponents.org" prefix="ec" %> <%@ taglib uri='http://java.sun.com/jsp/jstl/core' prefix='c'%> <%@ taglib uri="continuum" prefix="c1" %> <%@ taglib uri="http://plexus.codehaus.org/redback/taglib-1.0" prefix="redback" %> - + - - ${pageScope.buildDefinitionSummary.scheduleId} - - ${pageScope.buildDefinitionSummary.scheduleName} + + ${pageScope.buildDefinitionSummary.scheduleId} + + ${pageScope.buildDefinitionSummary.scheduleName} ${pageScope.buildDefinitionSummary.scheduleName} @@ -54,75 +54,75 @@ - - ${projectId} - ${pageScope.buildDefinitionSummary.id} - - - " alt="" title="" border="0"> + + ${projectId} + ${pageScope.buildDefinitionSummary.id} + + + " alt="" title="" border="0"> - " alt="" title="" border="0" /> + " alt="" title="" border="0" /> <%-- if the from is PROJECT then render the links differently --%> - + - - ${projectId} - ${pageScope.buildDefinitionSummary.id} - - " alt="" title="" border="0"> + + ${projectId} + ${pageScope.buildDefinitionSummary.id} + + " alt="" title="" border="0"> - " alt="" title="" border="0" /> + " alt="" title="" border="0" /> - - + + - - ${pageScope.buildDefinitionSummary.projectGroupId} - ${pageScope.buildDefinitionSummary.id} - true - - " alt="" title="" border="0"> + + ${pageScope.buildDefinitionSummary.projectGroupId} + ${pageScope.buildDefinitionSummary.id} + true + + " alt="" title="" border="0"> - " alt="" title="" border="0" /> + " alt="" title="" border="0" /> - + <%-- if the from is PROJECT then render the links differently --%> - + - - ${projectId} - ${pageScope.buildDefinitionSummary.id} - - - " alt="" title="" border="0"> + + ${projectId} + ${pageScope.buildDefinitionSummary.id} + + + " alt="" title="" border="0"> - " alt="" title="" border="0" /> + " alt="" title="" border="0" /> - - + + - - ${pageScope.buildDefinitionSummary.projectGroupId} - ${pageScope.buildDefinitionSummary.id} - true - - - " alt="" title="" border="0"> + + ${pageScope.buildDefinitionSummary.projectGroupId} + ${pageScope.buildDefinitionSummary.id} + true + + + " alt="" title="" border="0"> - " alt="" title="" border="0" /> + " alt="" title="" border="0" /> - + - + Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/companyLogo.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/companyLogo.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/companyLogo.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/companyLogo.jsp Wed Oct 22 22:05:36 2008 @@ -17,11 +17,11 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri="http://java.sun.com/jsp/jstl/core" prefix="c" %> - + - + Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/failureComponent.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/failureComponent.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/failureComponent.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/failureComponent.jsp Wed Oct 22 22:05:36 2008 @@ -17,11 +17,11 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri="http://www.extremecomponents.org" prefix="ec" %> <%@ taglib uri='http://java.sun.com/jsp/jstl/core' prefix='c'%> <%@ taglib uri="continuum" prefix="c1" %> - +
@@ -30,4 +30,4 @@
-
+ Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectGroupNotifierSummaryComponent.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectGroupNotifierSummaryComponent.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectGroupNotifierSummaryComponent.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectGroupNotifierSummaryComponent.jsp Wed Oct 22 22:05:36 2008 @@ -17,15 +17,15 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri="http://www.extremecomponents.org" prefix="ec" %> <%@ taglib uri='http://java.sun.com/jsp/jstl/core' prefix='c'%> <%@ taglib uri="continuum" prefix="c1" %> <%@ taglib uri="http://plexus.codehaus.org/redback/taglib-1.0" prefix="redback" %> - +

Project Group Notifiers of ${projectGroup.name} group

- + - - ${pageScope.projectGroupNotifierSummary.projectGroupId} - ${pageScope.projectGroupNotifierSummary.id} - ${pageScope.projectGroupNotifierSummary.type} - - - " alt="" title="" border="0"> - + + ${pageScope.projectGroupNotifierSummary.projectGroupId} + ${pageScope.projectGroupNotifierSummary.id} + ${pageScope.projectGroupNotifierSummary.type} + + + " alt="" title="" border="0"> + - " alt="" title="" border="0"> + " alt="" title="" border="0"> - - ${pageScope.projectGroupNotifierSummary.projectGroupId} - ${pageScope.projectGroupNotifierSummary.id} - ${pageScope.projectGroupNotifierSummary.type} - - - - " alt="" title="" border="0"> - + + ${pageScope.projectGroupNotifierSummary.projectGroupId} + ${pageScope.projectGroupNotifierSummary.id} + ${pageScope.projectGroupNotifierSummary.type} + + + + " alt="" title="" border="0"> + - " alt="" title="" border="0"> + " alt="" title="" border="0"> - +
- - - "/> - - + + + "/> + +
- +

Project Notifiers

- - - - ${pageScope.projectNotifierSummary.projectName} + + + + ${pageScope.projectNotifierSummary.projectName} @@ -107,51 +107,51 @@ - - ${pageScope.projectNotifierSummary.projectGroupId} - ${pageScope.projectNotifierSummary.projectId} - ${pageScope.projectNotifierSummary.id} - ${pageScope.projectNotifierSummary.type} - - - - " alt="" title="" border="0"> - + + ${pageScope.projectNotifierSummary.projectGroupId} + ${pageScope.projectNotifierSummary.projectId} + ${pageScope.projectNotifierSummary.id} + ${pageScope.projectNotifierSummary.type} + + + + " alt="" title="" border="0"> + - " alt="" title="" border="0"> + " alt="" title="" border="0"> - " alt="" title="" border="0"> + " alt="" title="" border="0"> - - ${pageScope.projectNotifierSummary.projectGroupId} - ${pageScope.projectNotifierSummary.projectId} - ${pageScope.projectNotifierSummary.id} - - - - - " alt="" title="" border="0"> - + + ${pageScope.projectNotifierSummary.projectGroupId} + ${pageScope.projectNotifierSummary.projectId} + ${pageScope.projectNotifierSummary.id} + + + + + " alt="" title="" border="0"> + - " alt="" title="" border="0"> + " alt="" title="" border="0"> - " alt="" title="" border="0"> + " alt="" title="" border="0"> -
-
+ + Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectGroupTabComponent.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectGroupTabComponent.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectGroupTabComponent.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectGroupTabComponent.jsp Wed Oct 22 22:05:36 2008 @@ -17,78 +17,78 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri="http://www.extremecomponents.org" prefix="ec" %> <%@ taglib uri='http://java.sun.com/jsp/jstl/core' prefix='c'%> <%@ taglib uri="continuum" prefix="c1" %> - +
- \ No newline at end of file + \ No newline at end of file Modified: continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectNotifierSummaryComponent.jsp URL: http://svn.apache.org/viewvc/continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectNotifierSummaryComponent.jsp?rev=707273&r1=707272&r2=707273&view=diff ============================================================================== --- continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectNotifierSummaryComponent.jsp (original) +++ continuum/branches/continuum-struts2/continuum-webapp/src/main/webapp/WEB-INF/jsp/components/projectNotifierSummaryComponent.jsp Wed Oct 22 22:05:36 2008 @@ -17,15 +17,15 @@ ~ under the License. --%> -<%@ taglib uri="/webwork" prefix="ww" %> +<%@ taglib uri="/struts-tags" prefix="s" %> <%@ taglib uri="http://www.extremecomponents.org" prefix="ec" %> <%@ taglib uri='http://java.sun.com/jsp/jstl/core' prefix='c'%> <%@ taglib uri="continuum" prefix="c1" %> <%@ taglib uri="http://plexus.codehaus.org/redback/taglib-1.0" prefix="redback" %> - + TODO: Implement Project Group Notifier Summary - \ No newline at end of file + \ No newline at end of file