continuum-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From eveni...@apache.org
Subject svn commit: r508164 - in /maven/continuum/trunk: continuum-core/src/main/java/org/apache/maven/continuum/core/action/ continuum-webapp/src/main/java/org/apache/maven/continuum/web/checks/security/
Date Thu, 15 Feb 2007 21:30:18 GMT
Author: evenisse
Date: Thu Feb 15 13:30:18 2007
New Revision: 508164

URL: http://svn.apache.org/viewvc?view=rev&rev=508164
Log:
o [CONTINUUM-1161] Add missing Default Project Group Administrator
o Remove project group administrator when the project group is removed

Modified:
    maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/AddAssignableRolesAction.java
    maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/RemoveAssignableRolesAction.java
    maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/checks/security/RoleProfileEnvironmentCheck.java

Modified: maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/AddAssignableRolesAction.java
URL: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/AddAssignableRolesAction.java?view=diff&rev=508164&r1=508163&r2=508164
==============================================================================
--- maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/AddAssignableRolesAction.java
(original)
+++ maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/AddAssignableRolesAction.java
Thu Feb 15 13:30:18 2007
@@ -54,7 +54,7 @@
     {
         int projectGroupId = getProjectGroupId( context );
 
-        ProjectGroup projectGroup = store.getProjectGroupWithBuildDetails( projectGroupId
);
+        ProjectGroup projectGroup = store.getProjectGroup( projectGroupId );
 
         // TODO: make the resource the name of the project group and hide the id from the
user
 

Modified: maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/RemoveAssignableRolesAction.java
URL: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/RemoveAssignableRolesAction.java?view=diff&rev=508164&r1=508163&r2=508164
==============================================================================
--- maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/RemoveAssignableRolesAction.java
(original)
+++ maven/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/core/action/RemoveAssignableRolesAction.java
Thu Feb 15 13:30:18 2007
@@ -57,6 +57,8 @@
 
         try
         {
+            roleManager.deleteDynamicRole( "continuum-group-project-administrator", projectGroup.getName()
);
+
             roleManager.deleteDynamicRole( "continuum-group-developer", projectGroup.getName()
);
 
             roleManager.deleteDynamicRole( "continuum-group-user", projectGroup.getName()
);

Modified: maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/checks/security/RoleProfileEnvironmentCheck.java
URL: http://svn.apache.org/viewvc/maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/checks/security/RoleProfileEnvironmentCheck.java?view=diff&rev=508164&r1=508163&r2=508164
==============================================================================
--- maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/checks/security/RoleProfileEnvironmentCheck.java
(original)
+++ maven/continuum/trunk/continuum-webapp/src/main/java/org/apache/maven/continuum/web/checks/security/RoleProfileEnvironmentCheck.java
Thu Feb 15 13:30:18 2007
@@ -70,6 +70,8 @@
                 ProjectGroup group = (ProjectGroup) i.next();
 
                 // gets the role, making it if it doesn't exist
+                //TODO: use continuum.executeAction( "add-assignable-roles", context ); or
something like that to avoid code duplication
+                continuumRoleManager.getDynamicRole( "continuum-group-project-administrator",
group.getName() );
                 continuumRoleManager.getDynamicRole( "continuum-group-user", group.getName()
);
                 continuumRoleManager.getDynamicRole( "continuum-group-developer", group.getName()
);
 



Mime
View raw message