concerted-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gaurav Shukla (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CONCERTED-18) insert_val and search_val function in ConcMat.h limits the search array size to 3
Date Sun, 01 Nov 2015 06:30:28 GMT

    [ https://issues.apache.org/jira/browse/CONCERTED-18?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14984279#comment-14984279
] 

Gaurav Shukla commented on CONCERTED-18:
----------------------------------------

I've made the whole structure more object oriented by moving the functions inside there respective
classes, And also the search function wasn't working, so I fixed it. Are there any tests I
could run to make sure I didn't break anything ?

[~atris], I wanted to know When do we change level, there's a level field in mat_node class
but that is never incremented ?


> insert_val and search_val function in ConcMat.h limits the search array size to 3
> ---------------------------------------------------------------------------------
>
>                 Key: CONCERTED-18
>                 URL: https://issues.apache.org/jira/browse/CONCERTED-18
>             Project: Apache Concerted
>          Issue Type: Bug
>            Reporter: Gaurav Shukla
>            Assignee: Gaurav Shukla
>            Priority: Minor
>              Labels: newbie
>
> insert_val and search_val function in ConcMat.h limits insert and search array size to
3 where as mat_node suports child attributes upto 10.
> So I think both the functions should allow searching and inserting upto a max of 10 or
if possible even the number of childs in mat_node should also be dynamic.
> mat_node* insert_val(int[3],mat_node*);
> mat_node* search_val(int search_val_array[3], mat_tree *tree_val)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message