concerted-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Julian Hyde <>
Subject Re: [MENTORS] Sending Patches
Date Fri, 23 Oct 2015 19:31:34 GMT
How you receive contributions (and also whether you do
review-then-commit or commit-then-review) is for the Concerted
community to decide.

For what it's worth, this is what we do in Calcite.

We allow (1) JIRA case plus a github PR, or (2) JIRA case + attached
patch. Commit messages must start with the JIRA case number. We prefer
(1). We have not implemented review board, and have not made a firm
policy about RTC vs CTR because our ad hoc policy has not been

But the Concerted community might choose an entirely different
process. We as mentors can advise whether the process you choose meets
Apache's needs for IP due diligence etc.


On Fri, Oct 23, 2015 at 12:18 PM, Jake Farrell <> wrote:
> The requirement is that the commit message format is all in a common format
> so it can be searchable, so would not restrict where the contributions come
> in from github and jira are the two most common paired together, and the
> ASF has a reviewboard instance available also. The github integrations will
> automatically comment on jira issue if the github pr has the ticket id in
> it.
> for Thrift we require that all patches have a ticket associated with them,
> our how to contribute guide is available at
> and for committers our how to
> commit
> - patch attached to jira
> - fork on github and pr (closed via commit message, would script applying
> and commit for this)
> - reviewboard (
> -Jake
> On Fri, Oct 23, 2015 at 2:56 PM, Atri Sharma <> wrote:
>> Hi Mentors,
>> I just wanted to check the best way of sending and committing patches.
>> One way is attach a patch to JIRA, committer applies it locally, reviews it
>> and then commits it.
>> One more way is to get pull request in github mirror.
>> I was thinking of second with patch to be attached as well to JIRA for
>> reference.
>> Please let me know your comments.
>> Regards,
>> Atri
>> --
>> Regards,
>> Atri
>> *l'apprenant*

View raw message