community-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "John D. Ament" <johndam...@apache.org>
Subject Re: Apache Project Maturity Model - CD50 - Commit Messages & Git
Date Wed, 30 Aug 2017 11:07:59 GMT
Ping? Let me know if I have the wrong list, I thought comdev maintained
this.

I've been in contact with two podlings, one publicly and one privately, who
both ran into an issue on this question (for the record, they both marked
yes, both use pull requests to accept contributions, and I pointed out to
them that commit messages from external contributors don't include the
information listed, they agreed when reading the question).  It seems to me
that using a pull request is valid, and it keeps enough provenance of the
code (git has a notion of an author and committer, so maybe we can just
mention that?).  It's just that the wording doesn't really line up with how
git works.

John

On Sun, Aug 27, 2017 at 9:24 PM John D. Ament <johndament@apache.org> wrote:

> Hi,
>
> I suspect that CD50 has a SVN or patch based history behind it.  When
> using pull requests via github, you can actually track the original
> committer (since reasonably they have raised the pull request).  it's
> actually their commit that ends up in our repo.
>
> So I'm wondering is there a way to restate this, to make it work when
> using pull requests?
>
> John
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message