community-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Suresh Marru <sma...@apache.org>
Subject Re: svn commit: r1468843 - /comdev/site/trunk/templates/standard.html
Date Wed, 17 Apr 2013 13:10:20 GMT
Thanks Uli, this is great feedback. I will get these changes as soon I get online.

Thanks,
Suresh

Sent from my iPhone

On Apr 17, 2013, at 8:57 AM, Ulrich Stärk <uli@spielviel.de> wrote:

> On 17.04.2013 13:30, smarru@apache.org wrote:
>> Author: smarru
>> Date: Wed Apr 17 11:30:20 2013
>> New Revision: 1468843
>> 
>> URL: http://svn.apache.org/r1468843
>> Log:
>> adding a google custom search box
>> 
>> Modified:
>>    comdev/site/trunk/templates/standard.html
>> 
>> Modified: comdev/site/trunk/templates/standard.html
>> URL: http://svn.apache.org/viewvc/comdev/site/trunk/templates/standard.html?rev=1468843&r1=1468842&r2=1468843&view=diff
>> ==============================================================================
>> --- comdev/site/trunk/templates/standard.html (original)
>> +++ comdev/site/trunk/templates/standard.html Wed Apr 17 11:30:20 2013
>> @@ -1,4 +1,4 @@
>> -<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
>> +<!DOCTYPE html>
>> <!--
>> 
>>     Licensed to the Apache Software Foundation (ASF) under one or more
>> @@ -22,7 +22,6 @@
>>   <META name="description" content="Apache Community Development"/>
>>   <META name="keywords" content="apache, apache community, community development,
opensource"/>
>> 
>> -
>>   <META http-equiv="Content-Type" content="text/html; charset=utf-8">
>> <!--      <LINK rel="stylesheet" href="/style/compressed.css" type="text/css"
media="screen, projection">
>>       <LINK rel="stylesheet" href="/style/style.css" type="text/css" media="screen,
projection"> -->
>> @@ -135,20 +134,42 @@
>>     </div>
>> 
>>   <div class="container">
>> -    <h3 class="muted">The Apache Software Foundation</h3>
>> -    <h4 class="muted">Meritocracy in Action.</h4>
>> +    <section id="content" class="row">
>> +      <div class="span9">
>> +        <h3 class="muted">The Apache Software Foundation</h3>
>> +      </div>
>> +      <div class="span3" class="pull-right"><gcse:search></gcse:search></div>
> 
> You meant class="span3 pull-right". Also, can you please make it HTML5-compliant [1]?
In addition,
> it looks a bit odd in the layout, you could try tweaking it. Bootstrap has a special
class for
> search boxes, we should use it.
> 
> Uli
> 
> 
> [1] https://developers.google.com/custom-search/docs/element#html5

Mime
View raw message