community-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1743210 - /comdev/reporter.apache.org/trunk/scripts/parsepmcs.py
Date Tue, 10 May 2016 15:18:12 GMT
Author: sebb
Date: Tue May 10 15:18:11 2016
New Revision: 1743210

URL: http://svn.apache.org/viewvc?rev=1743210&view=rev
Log:
Clarify check and message

Modified:
    comdev/reporter.apache.org/trunk/scripts/parsepmcs.py

Modified: comdev/reporter.apache.org/trunk/scripts/parsepmcs.py
URL: http://svn.apache.org/viewvc/comdev/reporter.apache.org/trunk/scripts/parsepmcs.py?rev=1743210&r1=1743209&r2=1743210&view=diff
==============================================================================
--- comdev/reporter.apache.org/trunk/scripts/parsepmcs.py (original)
+++ comdev/reporter.apache.org/trunk/scripts/parsepmcs.py Tue May 10 15:18:11 2016
@@ -123,23 +123,19 @@ for group in ldapgroups:
 
 
 """
-   The old code used people.apache.org which included podling groups.
-   We don't want these, and we need to remove any existing ones.
-   Otherwise we cannot determine when a podling graduates.
-   Proactively remove the nonldap groups. 
-   [This code can be removed in due course]
+    Check for inconsistencies in non-ldap groups
 """
 
 nonldapgroups = loadJson('https://whimsy.apache.org/public/public_nonldap_groups.json')['groups']
 for nongroup in sorted(nonldapgroups):
-    if nongroup not in ldapgroups: # should not happen, but check anyway
+    if nongroup in ldapgroups:
+        printMail("WARN: non-ldap group '%s' also present in unix group - should not happen"
% nongroup)
+    else:
         if nongroup in projects:
             print("Dropping non-ldap group %s" % nongroup)
             del projects[nongroup]
-#        else:
-#            print("Not found non-ldap group %s" % nongroup)
-    else:
-        printMail("WARN: unexpected non-ldap group '%s' in projects list " % nongroup)
+#         else: # e.g. podling or special interest group
+#             print("Not found non-ldap group %s" % nongroup)
 
 # Delete retired members
 ret = 0



Mime
View raw message