community-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject svn commit: r1733675 - /comdev/projects.apache.org/scripts/cronjobs/parsecommitters.py
Date Fri, 04 Mar 2016 23:23:59 GMT
Author: sebb
Date: Fri Mar  4 23:23:59 2016
New Revision: 1733675

URL: http://svn.apache.org/viewvc?rev=1733675&view=rev
Log:
non-LDAP groups can contain invalid entries; check this

Modified:
    comdev/projects.apache.org/scripts/cronjobs/parsecommitters.py

Modified: comdev/projects.apache.org/scripts/cronjobs/parsecommitters.py
URL: http://svn.apache.org/viewvc/comdev/projects.apache.org/scripts/cronjobs/parsecommitters.py?rev=1733675&r1=1733674&r2=1733675&view=diff
==============================================================================
--- comdev/projects.apache.org/scripts/cronjobs/parsecommitters.py (original)
+++ comdev/projects.apache.org/scripts/cronjobs/parsecommitters.py Fri Mar  4 23:23:59 2016
@@ -1,4 +1,5 @@
 import errtee
+import sys
 """
 
 Reads:
@@ -71,7 +72,11 @@ nonldapgroups = loadJson('https://whimsy
 for g in nonldapgroups:
     groups[g] = nonldapgroups[g]['roster']
     for p in nonldapgroups[g]['roster']:
-        addPersonGroup(p).append(g)
+        # N.B. non-LDAP groups can contain invalid entries; check this
+        if not p in ldappeople:
+            print("ERROR: non-LDAP group '%s' has entry '%s' not in people LDAP group" %
(g, p), file=sys.stderr)
+        else:
+            addPersonGroup(p).append(g)
 
 for g in ldapgroups:
     if not g == 'committers':



Mime
View raw message