community-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Girish Kumar Balachandran (JIRA)" <j...@apache.org>
Subject [jira] Closed: (COMDEV-33) File size is now calculated based on byte counting instead of looking @ the multipart header
Date Sat, 27 Mar 2010 01:30:27 GMT

     [ https://issues.apache.org/jira/browse/COMDEV-33?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Girish Kumar Balachandran closed COMDEV-33.
-------------------------------------------

    Resolution: Not A Problem

Sorry wrong project:(

> File size is now calculated based on byte counting instead of looking @ the multipart
header
> --------------------------------------------------------------------------------------------
>
>                 Key: COMDEV-33
>                 URL: https://issues.apache.org/jira/browse/COMDEV-33
>             Project:  	 Community Development 
>          Issue Type: Bug
>            Reporter: Girish Kumar Balachandran
>            Priority: Minor
>
> Currently, the UploadedFileProcessorImpl creates UploadedFileImpl object to pass it along
the chain.  UploadedFileImpl actually reads full stream and buffers the whole file in the
memory/file. While it buffers, it also does byte counts. 
> There is no real need to buffer the whole file content in the memory/file if the only
consumer is the final bean (via Valuechanged listener). We could just let the stream bypass
buffer and go right on to the end code.Currently we always buffer. The implementaion could
be easily changed to pass on the unbuffered FileUploadConfiguratorImpl:TempUploadedFile to
the bean, but this implementation does not fully implement dispose() and getLength() fully.
These two methods can be implemented with out scanning the whole bytes by just looking at
the multipart header information.
> Once this implementation is corrected, default UploadedFileProcessor could just return
TempUploadedFile that is not backed by a buffer.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message