commonsrdf-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From st...@apache.org
Subject [05/22] incubator-commonsrdf git commit: Tweaks for ignored tests
Date Sun, 23 Oct 2016 00:59:48 GMT
Tweaks for ignored tests


Project: http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/commit/17c0d271
Tree: http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/tree/17c0d271
Diff: http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/diff/17c0d271

Branch: refs/heads/COMMONSRDF-46
Commit: 17c0d271cc17b61806ec8735ca2f82e0c4bd6050
Parents: 2a6fefa
Author: Stian Soiland-Reyes <stain@apache.org>
Authored: Wed Oct 19 17:26:11 2016 +0100
Committer: Stian Soiland-Reyes <stain@apache.org>
Committed: Wed Oct 19 17:26:11 2016 +0100

----------------------------------------------------------------------
 .../org/apache/commons/rdf/jsonldjava/JsonLdBlankNode.java     | 1 +
 .../org/apache/commons/rdf/jsonldjava/JsonLdFactoryTest.java   | 6 ++++--
 .../org/apache/commons/rdf/rdf4j/MemoryRDFTermFactoryTest.java | 2 +-
 .../org/apache/commons/rdf/rdf4j/Rdf4JRDFTermFactoryTest.java  | 2 +-
 4 files changed, 7 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/blob/17c0d271/jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdBlankNode.java
----------------------------------------------------------------------
diff --git a/jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdBlankNode.java
b/jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdBlankNode.java
index b079c14..0a7d59c 100644
--- a/jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdBlankNode.java
+++ b/jsonld-java/src/main/java/org/apache/commons/rdf/jsonldjava/JsonLdBlankNode.java
@@ -37,6 +37,7 @@ public interface JsonLdBlankNode extends JsonLdTerm, BlankNode {
 	
 		@Override
 		public String ntriplesString() {
+			// TODO: Escape if this is not valid ntriples string (e.g. contains :)
 			return node.getValue();
 		}
 	

http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/blob/17c0d271/jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdFactoryTest.java
----------------------------------------------------------------------
diff --git a/jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdFactoryTest.java
b/jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdFactoryTest.java
index 02b2695..fd65c2a 100644
--- a/jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdFactoryTest.java
+++ b/jsonld-java/src/test/java/org/apache/commons/rdf/jsonldjava/JsonLdFactoryTest.java
@@ -19,6 +19,7 @@ package org.apache.commons.rdf.jsonldjava;
 
 import org.apache.commons.rdf.api.AbstractRDFTermFactoryTest;
 import org.apache.commons.rdf.api.RDFFactory;
+import org.junit.Assume;
 import org.junit.Ignore;
 import org.junit.Test;
 
@@ -31,17 +32,17 @@ public class JsonLdFactoryTest extends AbstractRDFTermFactoryTest {
 	
 	// TODO: Add support for checking for invalid lang/iri/blanknode IDs
 	
-	@Ignore
 	@Test
 	@Override
 	public void testInvalidLiteralLang() throws Exception {
+		Assume.assumeFalse("JSONLD-Java does not validate lang strings", false);		
 		super.testInvalidLiteralLang();
 	}
 	
-	@Ignore
 	@Test
 	@Override
 	public void testInvalidIRI() throws Exception {
+		Assume.assumeFalse("JSONLD-Java does not validate IRIs", false);
 		super.testInvalidIRI();
 	}
 	
@@ -49,6 +50,7 @@ public class JsonLdFactoryTest extends AbstractRDFTermFactoryTest {
 	@Test
 	@Override
 	public void testPossiblyInvalidBlankNode() throws Exception {
+		// TODO: Fix blank node in ntriplesString()
 		super.testPossiblyInvalidBlankNode();
 	}
 }

http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/blob/17c0d271/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/MemoryRDFTermFactoryTest.java
----------------------------------------------------------------------
diff --git a/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/MemoryRDFTermFactoryTest.java
b/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/MemoryRDFTermFactoryTest.java
index 07d6a13..99beb54 100644
--- a/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/MemoryRDFTermFactoryTest.java
+++ b/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/MemoryRDFTermFactoryTest.java
@@ -30,7 +30,7 @@ public class MemoryRDFTermFactoryTest extends AbstractRDFTermFactoryTest
{
 	
 	@Override
 	public void testInvalidLiteralLang() throws Exception {
-		Assume.assumeTrue("Sesame doesn't check Lang strings",false);
+		Assume.assumeTrue("RDF4J doesn't check Lang strings",false);
 		super.testInvalidLiteralLang();
 	}
 	

http://git-wip-us.apache.org/repos/asf/incubator-commonsrdf/blob/17c0d271/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/Rdf4JRDFTermFactoryTest.java
----------------------------------------------------------------------
diff --git a/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/Rdf4JRDFTermFactoryTest.java
b/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/Rdf4JRDFTermFactoryTest.java
index 4e075ac..1185bc5 100644
--- a/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/Rdf4JRDFTermFactoryTest.java
+++ b/rdf4j/src/test/java/org/apache/commons/rdf/rdf4j/Rdf4JRDFTermFactoryTest.java
@@ -30,7 +30,7 @@ public class Rdf4JRDFTermFactoryTest extends AbstractRDFTermFactoryTest
{
 	
 	@Override
 	public void testInvalidLiteralLang() throws Exception {
-		Assume.assumeTrue("Sesame doesn't check Lang strings",false);
+		Assume.assumeTrue("RDD4J doesn't check Lang strings",false);
 		super.testInvalidLiteralLang();
 	}
 	


Mime
View raw message