commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bruno P. Kinoshita" <brunodepau...@yahoo.com.br.INVALID>
Subject Re: [POOL] EvictionTimer daemon thread
Date Wed, 31 Jan 2018 08:15:35 GMT
Not sure if it was intentional.

But here's the reason: https://github.com/apache/commons-pool/commit/4a20cdca923bd342360f821d7020538e985d9ec2#diff-38e254894b87bdf9a1758778c7ffd50fL167

Instead of a `new Timer("", /* isDaemon */ true)`, now we have an implementation of `ThreadFactory`
that when it creates new `Thread`s, it doesn't set the `setDaemon(true)`. So it just creates
a thread with default behaviour of daemon set to false.

As the previous behaviour was to have the threads as daemon, and there doesn't seem to have
any arguments for dropping it, we could raise a new issue, with a patch, and ping Mark to
see what he thinks?

Cheers
Bruno

(ps: the threads have a typo in their names, but it has been fixed in the master branch already)


________________________________
From: "Wegrzyn, Jakub" <Jakub.Wegrzyn@sabre.com>
To: Commons Users List <user@commons.apache.org> 
Sent: Wednesday, 31 January 2018 8:54 PM
Subject: RE: [POOL] EvictionTimer daemon thread



I couldn’t find it either.
Pool-351 was a commit message. 
https://git-wip-us.apache.org/repos/asf?p=commons-pool.git;a=commit;h=4a20cdca923bd342360f821d7020538e985d9ec2

Jakub 


-----Original Message-----
From: Gary Gregory [mailto:garydgregory@gmail.com] 
Sent: Wednesday, January 31, 2018 8:28 AM
To: Commons Users List <user@commons.apache.org>
Subject: Re: [POOL] EvictionTimer daemon thread

I cannot find a POOL-351 issue. Can you double check please?

Gary

On Jan 31, 2018 00:15, "Wegrzyn, Jakub" <Jakub.Wegrzyn@sabre.com> wrote:

> Hi,
>
> We want to upgrade dbcp2 from version 2.1.1 to version 2.2.0. It 
> requires upgrading commons-pool2 from version 2.4.2 to 2.5.0. However, 
> during the upgrade we encountered a problem.
> It seems that commons-pool2 Evictor thread has been changed from 
> daemon to non-daemon thread (Issue POOL-351, commit: 
> 4a20cdca923bd342360f821d702053 8e985d9ec2).
>
> We cannot find any documentation describing the reason or the change 
> itself. Can you provide more insight why that was changed and add it 
> to the changes-report.
>
> Best regards,
> Jakub
>
B�KKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKKCB��[��X��ܚX�KK[XZ[�\�\�][��X��ܚX�P��[[ۜ˘\X�K�ܙ�B��܈Y][ۘ[��[X[��K[XZ[�\�\�Z[��[[ۜ˘\X�K�ܙ�B�

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org


Mime
View raw message