Mailing-List: contact user-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Users List" <user@commons.apache.org>
From: Rob Tompkins <chtompki@apache.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Reply-To: Commons Users List <user@commons.apache.org>
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [SECURITY] CVE-2017-12621 Apache Commons Jelly connects to URL with
 custom doctype definitions.
Date: Wed, 27 Sep 2017 09:05:46 -0400
Message-Id: <38CA08B7-2456-4D56-AF60-BE1168ECE522@apache.org>
Cc: security@apache.org,
 "<private@commons.apache.org>" <private@commons.apache.org>
To: announce@apache.org,
 Commons Developers List <dev@commons.apache.org>,
 Commons Users List <user@commons.apache.org>,
 Luca Carettoni <luca@doyensec.com>,
 oss-security@lists.openwall.com
archived-at: Wed, 27 Sep 2017 13:05:58 -0000

CVE-2017-12621: Apache Commons Jelly connects to URL with custom doctype =
definitions.

Severity: Medium

Vendor:
The Apache Software Foundation

Versions Affected:
commons-jelly-1.0 (core), namely commons-jelly-1.0.jar

Description:
During Jelly (xml) file parsing with Apache Xerces, if a custom doctype =
entity is declared with a =E2=80=9CSYSTEM=E2=80=9D entity with a URL and =
that entity is used in the body of the Jelly file, during parser =
instantiation the parser will attempt to connect to said URL. This could =
lead to XML External Entity (XXE) attacks. The Open Web Application =
Security Project suggests that the fix be =
https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Prevention_Cheat=
_Sheet#XMLReader

Mitigation:
1.0 users should migrate to 1.0.1.

Example:

example.jelly
--------------
<?xml version=3D"1.0"?>
<!---
 Licensed to the Apache Software Foundation (ASF) under one or more
 contributor license agreements.  See the NOTICE file distributed with
 this work for additional information regarding copyright ownership.
 The ASF licenses this file to You under the Apache License, Version 2.0
 (the "License"); you may not use this file except in compliance with
 the License.  You may obtain a copy of the License at
      http://www.apache.org/licenses/LICENSE-2.0
 Unless required by applicable law or agreed to in writing, software
 distributed under the License is distributed on an "AS IS" BASIS,
 WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or =
implied.
 See the License for the specific language governing permissions and
 limitations under the License.
-->
<!DOCTYPE r [
        <!ELEMENT r ANY >
        <!ENTITY sp SYSTEM "http://127.0.0.1:4444/">
        ]>
<r>&sp;</r>
<j:jelly trim=3D"false" xmlns:j=3D"jelly:core"
         xmlns:x=3D"jelly:xml"
         xmlns:html=3D"jelly:html">
</j:jelly>
--------------

ExampleParser.java
------------------
public class ExampleParser {
=09
	public static void main(String[] args) throws JellyException, =
IOException,=20
					NoSuchMethodException, =
IllegalAccessException,IllegalArgumentException,=20
					InvocationTargetException {
		JellyContext context =3D new JellyContext();
		context.runScript("example.jelly", null);
	}
}

Credit:
This was discovered by Luca Carettoni of Doyensec.

References:
[1] http://commons.apache.org/jelly/security-reports.html
[2] https://issues.apache.org/jira/browse/JELLY-293


---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org