Mailing-List: contact user-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Users List" <user@commons.apache.org>
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\))
Subject: Re: [validator] EmailValidator accept empty domain names
From: Ralph Goers <ralph.goers@dslextreme.com>
In-Reply-To: 
 <CAFdoKy8-aBKezJHG=dpfhVsqGhn8BU3KwCsqVJDjsbjFU1p3og@mail.gmail.com>
Date: Sun, 25 Oct 2015 00:07:21 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <9D946DD1-06B2-42B1-B951-DB37C7BB8A7A@dslextreme.com>
References: 
 <CAFdoKy8-aBKezJHG=dpfhVsqGhn8BU3KwCsqVJDjsbjFU1p3og@mail.gmail.com>
To: Commons Users List <user@commons.apache.org>

Please see VALIDATOR-376. I just committed the fix for this. FYI - =
commons-validator 1.4 does not have this behavior.

Ralph


> On Oct 22, 2015, at 12:05 AM, S=C3=A9bastien De Nef =
<sebastien.denef@gmail.com> wrote:
>=20
> Hi everybody,
>=20
> First, sorry for my english.
>=20
> I tried the EmailValidator component and I was surprised that it =
accepts a
> domain part that contains only the TLD (like joe@.org). See below a =
failing
> test.
>=20
> Although domainValidator.isValid(domain) returns false
> domainValidator.isValid(domain) || domainValidator.isValidTld(domain)
> returns true
> Is it the source of the problem ? Why does it bypass the domain =
validation
> if the TLD is valid ?
> NB: DomainValidator.isValid already contains isValidTld()
>=20
> S=C3=A9bastien
>=20
> /**
> * Tests the email validation for empty domain.
> */
> public void testEmailWithEmptyDomain()  {
>    assertFalse("empty domain name should fail",
> emailValidator.commonsValidator("joe@"));
>    assertFalse("domain name starting with dot should fail",
> emailValidator.commonsValidator("joe@.apache.org"));
>    assertFalse("domain name with only TLD should fail",
> emailValidator.commonsValidator("joe@.org")); // yes or no ?
> }


---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org