Mailing-List: contact user-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Users List" <user@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of thomas.neidhart@gmail.com
 designates 209.85.128.51 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <510ECEF0.7000308@gmail.com>
References: 
 <CA+GjePV7KTpfpvuCDsY6u5q3B+m0v7b-fzxTVHUfdA2r-bL2YQ@mail.gmail.com>
	<CAB_f4-XWv6-85uA8a0EdBDVtD06UKhTCNY_zEBcqUHMMdesXtA@mail.gmail.com>
	<CA+GjePWHKJNWPagkgijsjT4LEuO5v_PU_Tv6MhctQkFgtQJBVg@mail.gmail.com>
	<DA9D9620-0F55-4924-B007-F7FA1855B4F8@carmanconsulting.com>
	<CA+GjePUdVTtJ8ygMza3wgOGKQ2XcH9TEQBUxV2f66rnJbB0sPQ@mail.gmail.com>
	<CA+GjePUCzpB=Yq-KXT7_7BtQGScTiwKxQuXBpzQ2PK_FR3NEtg@mail.gmail.com>
	<510ECEF0.7000308@gmail.com>
Date: Tue, 5 Feb 2013 10:17:15 +0100
Message-ID: 
 <CAJSjvwsCo=a74Titi7E3WRysO5aY_046xMJvyKNUTjF=HpeeKQ@mail.gmail.com>
Subject: Re: [CLI] - withValueSeparator() usage
From: Thomas Neidhart <thomas.neidhart@gmail.com>
To: Commons Users List <user@commons.apache.org>
Content-Type: multipart/alternative; boundary=047d7bd6b99cf5019304d4f6ac12

--047d7bd6b99cf5019304d4f6ac12
Content-Type: text/plain; charset=ISO-8859-1

On Sun, Feb 3, 2013 at 9:56 PM, Thomas Neidhart
<thomas.neidhart@gmail.com>wrote:

> On 02/03/2013 06:29 PM, Greg Thomas wrote:
> > I've had a look; I the only place that could do with clarification is
> > the javadoc for getOptionValues @
> >
> http://commons.apache.org/cli/api-release/org/apache/commons/cli/CommandLine.html#getOptionValues(java.lang.String)
> > /
> http://commons.apache.org/cli/api-release/org/apache/commons/cli/CommandLine.html#getOptionValues(char)
> >
> > Currently, both say:
> >
> > "Retrieves the array of values, if any, of an option."
> >
> > I'd suggest something like;
> >
> > Where a valueSeparator is used to separate two argument values, these
> > will return both values in an array of length 2.
> > @see OptionBuilder#withValueSeparator()
>
> I think the examples provided in OptionBuilder#withValueSeparator() and
> OptionBulder#withValueSeparator(char) should be improved to clearly
> indicate that this separator is only used to distinguish between key and
> value, and not to split values itself.
>

I did look further into this issue, and

The value separator is only used in the Option#processValue method and is
indeed used to split the argument into multiple values.
Now, the splitting is only performed if in the OptionBuilder, the hasArgs()
is specified with the number of expected argument values.
With the default setting of hasArg(), like in the example above, no
splitting will be performed.

The example above also worked, because the option and arguments are
separated by whitespace and thus provided as separate tokens to the parser.
In this case, the argument is always the next token, regardless of the
separator. If you would specify hasArgs(3), you would indeed get the values
split into an array of 3 strings.

Thomas

--047d7bd6b99cf5019304d4f6ac12--