Mailing-List: contact user-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Users List" <user@commons.apache.org>
Received-SPF: neutral (athena.apache.org: local policy)
Message-ID: <4F8FA80A.1060607@oliver-heger.de>
Date: Thu, 19 Apr 2012 07:52:10 +0200
From: Oliver Heger <oliver.heger@oliver-heger.de>
User-Agent: Mozilla/5.0 (Windows NT 6.1;
 rv:11.0) Gecko/20120312 Thunderbird/11.0
MIME-Version: 1.0
To: Commons Users List <user@commons.apache.org>
Subject: Re: synchronization and XMLPropertiesConfiguration
References: 
 <CAKxqpUisn+bJmngAgHHyPCL5WDHS2SLTvja0yhHDTYND+HUBMA@mail.gmail.com>
 <4F8F18AF.4030402@oliver-heger.de>
 <CAKxqpUhc2VxXOEuJQFkLzZd7z9BbPgZG4+0TWYkj8vp=YcxtqQ@mail.gmail.com>
In-Reply-To: 
 <CAKxqpUhc2VxXOEuJQFkLzZd7z9BbPgZG4+0TWYkj8vp=YcxtqQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Am 18.04.2012 23:35, schrieb Julien Wajsberg:
> Hi Olivier,
>
> On 18 April 2012 21:40, Oliver Heger<oliver.heger@oliver-heger.de>  wrote:
>>>
>>> As I understand it, modifying the object means changing one of its
>>> core values, like the file to load from/save to, the encoding, etc. It
>>> doesn't mean adding or setting a property. Is that true ?
>>
>>
>> No, the configuration's properties are also affected. Internally, they are
>> stored in node-like structures which are not synchronized against concurrent
>> access. Therefore concurrent modifications can have unexpected results.
>
> However, it seems like setProperty is synchronized with the reloadLock as well ?
> (see http://grepcode.com/file/repo1.maven.org/maven2/commons-configuration/commons-configuration/1.8/org/apache/commons/configuration/AbstractFileConfiguration.java#AbstractFileConfiguration.setProperty%28java.lang.String%2Cjava.lang.Object%29)
>
> Am I missing something ?
You are right.

Originally access to properties was not thread-safe. Later on changes 
have been made to support concurrent access, so my information is not 
up-to-date.

However, I was not the author, and I am not sure whether really all 
access paths are synchronized.

Oliver

>
> Thanks


---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org