Mailing-List: contact user-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Users List" <user@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of gcjcu-commons-user@m.gmane.org
 designates 80.91.229.12 as permitted sender)
Mail-Followup-To: user@commons.apache.org
To: user@commons.apache.org
From: =?UTF-8?B?SsO2cmc=?= Schaible <joerg.schaible@gmx.de>
Subject: Re: [io] Should "FileUtils.writeByteArrayToFile(...)" not use a
 BufferedOutputStream?
Followup-To: gmane.comp.jakarta.commons.user
Date: Sun, 25 Sep 2011 19:54:40 +0200
Lines: 43
Message-ID: <j5npt0$de3$1@dough.gmane.org>
References: <315452501.20110920232739@the-cr.de>
 <1962583320.20110925184553@the-cr.de>
Reply-To: joerg.schaible@gmx.de
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8Bit
Mail-Copies-To: nobody
User-Agent: KNode/4.4.11

Hi Timo,

Timo Rumland wrote:

> Hello everyone,
> 
> sorry to bump this, but does anyone not have a comment to my question?
> I really think I missed something, I can't imagine that the Commons IO
> "forgot" to buffer the bytes that should be written to a file.
> 
> Please see my original question below.

Why should it? You provide all the bytes which are written immediately and 
the stream is closed afterwards. So what should a buffer be good for except 
for decreasing performance?

- Jörg

> 
> Thanks a lot!
> 
> -------------------------------------
> 
>> Hello,
> 
>> I recently started using the FileUtils class of Commons IO, and had a
>> quick look into the source code.
> 
>> The method "FileUtils.writeByteArrayToFile(...)" internally uses the
>> private method "openOutputStream(...)", which creates (after some
>> smart checks) an FileOutputStream.
> 
>> But, shouldn't "writeByteArrayToFile(...)" or "openOutputStream(...)"
>> not use/create a BufferedOutputStream, wrapping the FileOutputStream?
> 
>> Or do I overlook something?
> 
>> I think one should always buffer the bytes when writing to a file...
> 
>> Any thoughts?
> 
>> Thanks !


---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org