commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henri Yandell <>
Subject Re: Bug in StringUtils.equals()
Date Wed, 31 Aug 2011 05:45:26 GMT
On Tue, Aug 30, 2011 at 1:59 PM, sebb <> wrote:
> On 30 August 2011 19:08,  <> wrote:
>> Hi All,
>> i found a Bug in lang3. This tests are failed:
>> Assert.assertTrue(org.apache.commons.lang3.StringUtils.equals(new StringBuffer(""),
new StringBuffer("")));
>> Assert.assertTrue(org.apache.commons.lang3.StringUtils.equals(new StringBuffer("123"),
new StringBuffer("123")));
> The CharSequence interface does not define equals(), so only concrete
> implementations that provide one (such as String) will use anything
> other than Object.equals().
> I don't think this is a bug though perhaps the Javadoc could be clearer.

I think a warning in StringUtils.equals that StringBuffer and
StringBuilder don't implement equals as you'd expect and to call
toString before calling such would be valuable.

I think it's weird that the JDK doesn't do a real equals, but I don't
think it's something we should try to fix.


To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message