Mailing-List: contact user-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Users List" <user@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of paulus.benedictus@gmail.com
 designates 209.85.212.43 as permitted sender)
MIME-Version: 1.0
Sender: paulus.benedictus@gmail.com
In-Reply-To: 
 <47BE868E7D83AB47B70DB33395F669E2192ABAFF@SWI007.ams.intra.schiphol.nl>
References: 
 <47BE868E7D83AB47B70DB33395F669E2192ABAFF@SWI007.ams.intra.schiphol.nl>
Date: Wed, 27 Jul 2011 12:14:41 -0500
Message-ID: 
 <CABLGb9wap_DYt1kD5VreZZqc68SJFPqYFezWCN+S4oWiQgekFQ@mail.gmail.com>
Subject: Re: [lang] Advise needed for broken reflectionEquals in WebLogic
 10.3.5
From: Paul Benedict <pbenedict@apache.org>
To: Commons Users List <user@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

ReflectionEquals uses actual fields, not methods, to build the string
output. The underscore is actually a known convention by some Java
programmers (I don't subscribe to it but projects like Apache Tapestry
use underscore for ALL their fields). So I don't think underscore is
suitable to be excluded. However, perhaps as an enhancement the
builder could be configured with a list of prefixes to ignore. If
that's what you want, please open up a JIRA issue for consideration.

On Wed, Jul 27, 2011 at 11:49 AM, Cancrinus, Bas
<cancrinus_b@schiphol.nl> wrote:
> I'm currently migrating an EAR from WebLogic 10.3.3 to 10.3.5. While test=
ing I noticed that the following invocation returned false while I expected=
 true (lang 2.5):
>
> EqualsBuilder.reflectionEquals(Object lhs, Object rhs, String[] excludeFi=
elds)
>
> I noticed in my debugger that my domain classes were extended by the WebL=
ogic JPA provider with the following field:
>
> protected org.eclipse.persistence.queries.FetchGroup _persistence_fetchGr=
oup
>
> EqualsBuilder.reflectionAppend() (lang 2.5-3.0) only ignores:
>
> - =A0 =A0 =A0 =A0 =A0"$" in field names
>
> - =A0 =A0 =A0 =A0 =A0static modifiers
>
> - =A0 =A0 =A0 =A0 =A0transients (conditional)
>
> - =A0 =A0 =A0 =A0 =A0and of course the excludeFields array
>
> The JPA extension field mentioned above doesn't fall into any of those ca=
tegories, so it is appended to the equals result.
>
> The easy way out for me would be to add this field to all reflectionEqual=
s excludeFields arrays, but I'm looking for a more sustainable way to do th=
is.
>
> - =A0 =A0 =A0 =A0 =A0What do you think about patching EqualsBuilder.refle=
ctionAppend() so that it ignores this field ( f.startsWith("_") )?
>
> - =A0 =A0 =A0 =A0 =A0Are there any other better ways to fix this issue?
>
> I appreciate any help very much!
>
> Have a nice day,
> Bas
>
>
> P: Please consider the environment before printing this e-mail
>
> ________________________________
>
> This e-mail may contain confidential and privileged material. You are req=
uested not to disclose, copy or distribute any information thereof. If you =
are not the intended recipient (or have received this e-mail in error) plea=
se notify the sender immediately and delete this e-mail. We accept no liabi=
lity for damage related to data and/or documents which are communicated by =
electronic mail.
>
> ________________________________
>

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org