Mailing-List: contact user-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Users List" <user@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of niall.pemberton@gmail.com
 designates 209.85.214.43 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=PKtkO+x6gtpJingPGJLD1uOtCKOFCzaEbv/z0JWlqkCtMyposOGxiuCEa9jm6VFJz/
         pPhYfFwSiI6ij2IRQr53WPyWNi1yuf0kMAygASTDXHVvqJiO0ZVMmYo9X68nNkzYfWU7
         eSdz1X0BtbTTkX9sM7RUtMBwWx3UcUF7yiJFI=
MIME-Version: 1.0
In-Reply-To: <4CA380E1.4030706@christopherschultz.net>
References: <4CA380E1.4030706@christopherschultz.net>
Date: Tue, 5 Oct 2010 20:05:04 +0100
Message-ID: <AANLkTikzdhiRpGUrDkdcQCicENCA6gcvqOy8Oned0uyv@mail.gmail.com>
Subject: Re: [validator] Possible to configure multiple error messages for a
 single validator?
From: Niall Pemberton <niall.pemberton@gmail.com>
To: Commons Users List <user@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

On Wed, Sep 29, 2010 at 7:09 PM, Christopher Schultz
<chris@christopherschultz.net> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> All,
>
> I've been happily using commons-validator 1.3.1 with Struts 1.3 for some
> years, now, and I've recently developed my own custom validator that
> checks for XHTML syntactic validity. Technically, it checks for XHTML
> validity only when the input looks like this: "<html>....</html>":
> everything else validates successfully with no actual XHTML syntax check.
>
> Recently, it became clear that users were sometimes forgetting the
> "</html>" at the end of the input. This caused two problems: first, the
> input wasn't being validated as XHTML, and second, when the data was
> then displayed in a web page, it was escaped instead of being rendered
> as actual HTML.
>
> My first instinct was to add a "mask" validator that checked for an
> appropriate pattern (that is, "<html>" up front with no trailing
> "</html>"). I implemented that and it works quite well. Then, it
> occurred to me that I might want some other pattern for some reason for
> those fields, and that the correct place for that check ought to be in
> the XHTML validator itself.
>
> So I started moving the check described above into my custom validator.
> Everything was fine until I had to render the error message. Since I'm
> doing essentially two checks (one for <html> and matching </html>, and a
> second for actually checking the XHTML syntax), I need two distinct
> error messages. The configuration for a validator only allows one single
> "msg" attribute as shown in my configuration below:
>
> =A0 =A0 =A0<validator name=3D"possibleXhtml"
> =A0 =A0 =A0 =A0 =A0 =A0classname=3D"....PossibleXhtmlValidator"
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 method=3D"validatePossibleXhtml"
> =A0 =A0 =A0 =A0 methodParams=3D"java.lang.Object,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 org.apache.commons.validator.=
ValidatorAction,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 org.apache.commons.validator.=
Field,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 org.apache.struts.action.Acti=
onMessages,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 org.apache.commons.validator.=
Validator,
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 javax.servlet.http.HttpServle=
tRequest"
> =A0 =A0 =A0 =A0 =A0 =A0 =A0depends=3D""
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0msg=3D"errors.xhtml" />
>
> I could simply hard-code the error message key into the validator, but
> that seems less maintainable than I'd like it to be. Is it possible to
> provide more than one error message key to a validator like this?
>
> Other options for me include creating a custom validator that does
> nothing but check for the <html>...</html> that won't interfere with,
> say, the "mask" validator.
>
> It still seems to me that my goal ought to be a single validator that is
> basically self-contained, rather than having two validators that
> essentially /must/ be used together.
>
> Does anyone have any suggestions?

Its been a long time since I worked with Stuts & Validator, but take a
look at the *standard* validators defined in struts:

http://svn.apache.org/viewvc/struts/struts1/trunk/core/src/main/java/org/ap=
ache/struts/validator/FieldChecks.java?view=3Dmarkup

Its the validation implementation that actually adds the messages to
the Struts ActionMessages object - usually by calling

   Resources.getActionMessage(validator, request, va, field))

http://svn.apache.org/viewvc/struts/struts1/trunk/core/src/main/java/org/ap=
ache/struts/validator/Resources.java?view=3Dmarkup

So you need to create your own custom getActionMessage() impl - you
could use the "msg" returned from the field or validator and use that
as a prefix and append a different suffix for each error.

Alternatively you could define two separate validators - one for each condi=
tion.

Niall


> Thanks,
> - -chris
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.10 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
>
> iEYEARECAAYFAkyjgOEACgkQ9CaO5/Lv0PBkWwCgjCeACyxBWyv7C4017lfBeMB0
> W6AAnioNsVh8uTgjWCPMIHuKIi6AUTLU
> =3D7DAj
> -----END PGP SIGNATURE-----
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
> For additional commands, e-mail: user-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org