Mailing-List: contact user-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Users List" <user@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of juliusdavies@gmail.com
 designates 209.85.160.51 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=dRk6iWRBY4g/7d8jrMbTnwuevwCAvMoME8/9Pf/ITPP/2tSqv5RAMH+zQplgxuccow
         HypY6gf1R8hmzvQEG8Yf8w7btX6hoh/Cg8dUcr7Vdn5qZGx/wbvte07xijp8YuNrM3db
         s1O0DI/tudOytJD15/TcI+UaPJyx8C9wCtSdw=
MIME-Version: 1.0
In-Reply-To: <d5eb7dbb0912030905n69a36bctbea9c5c27b131cb1@mail.gmail.com>
References: <d5eb7dbb0912030905n69a36bctbea9c5c27b131cb1@mail.gmail.com>
Date: Thu, 3 Dec 2009 13:38:18 -0800
Message-ID: <598ad5b50912031338s7d6767e1ked61a5467ce565f6@mail.gmail.com>
Subject: Re: Commons Codec: base64 "strict" mode?
From: Julius Davies <juliusdavies@gmail.com>
To: Commons Users List <user@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hi, Adam,

It doesn't currently do that.  Also, Base64 seamlessly decodes
URL_SAFE and REGULAR encodings, as well as mixes of the two, even
though a mix or URL_SAFE and REGULAR would technically be invalid.

I'm not a committer, but I could certainly put together a patch for a
strict mode.  Something like this?

1.  If character is not whitespace, and is not valid, throw exception.

2.  If character is inappropriate for our current mode (URL_SAFE or
REGULAR), throw exception.

3.  Note:  Personally I think it's too much trouble to detect weird
things like =3D=3D=3D (technically only at most =3D=3D should ever exist), =
or
characters after =3D=3D.  What do you think?


ps.  I'd probably do it as a subclass:  Base64Strict extends Base64


yours,

Julius


On Thu, Dec 3, 2009 at 9:05 AM, Adam Rabung <adamrabung@gmail.com> wrote:
> Hello,
> Currently, Codec skips base64 characters that are outside of the
> encode table. =A0I realize this is perfectly to spec, but I wonder if
> other users might appreciate a "strict" mode that throws an exception
> when one of these illegal characters are encountered. =A0For example, I
> would love an exception to be thrown here:
> new Base64().decode("!@#$ iHaveIllegalCharsAtBeginningAndEnd %^&"));
>
> My apologies if I'm missing the point or if this functionality already ex=
ists,
> Adam
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
> For additional commands, e-mail: user-help@commons.apache.org
>
>


--=20
yours,

Julius Davies
250-592-2284 (Home)
250-893-4579 (Mobile)
http://juliusdavies.ca/logging.html

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org