commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [LANG] Add FastUrlEncoder class from Google's Data API
Date Thu, 10 Jul 2008 19:48:42 GMT
On 10/07/2008, Travis Reeder <treeder@gmail.com> wrote:
> Read the javadoc that explains this class. Seems like a good thing for
>  commons-lang to have so any project can benefit from it.
>
>  http://code.google.com/p/gdata-java-client/source/browse/trunk/java/src/com/google/gdata/util/httputil/FastURLEncoder.java
>
>  Thoughts?
>

It's not thread-safe - in fact it is thread-hostile because of the
static verifyAgainstJava variable.

It also uses java util logging, which may not be desirable for LANG.

But I suppose those parts are not essential to the class and could be removed.

>
>  Travis
>

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org


Mime
View raw message