Mailing-List: contact user-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Users List" <user@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of niall.pemberton@gmail.com
 designates 72.14.204.228 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=message-id:date:from:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=mfTxH5HUY91slu+YFudC65BkNzKOKjSN2ajeO28SoinNWP43SbTWJP6b6m6bwCtBI12N7Km4JM+kjKo5499kviWtCUXbFQk12LCj89gnPHmQp1eguVh268zdrnKDsei8Gax84UWJ1CYmW7Lf8qDxTMwFcpbvqATtfyIYdOtYjpc=
Message-ID: <55afdc850802201655o48a1aeadv1ed640cbfb46cc77@mail.gmail.com>
Date: Thu, 21 Feb 2008 00:55:12 +0000
From: "Niall Pemberton" <niall.pemberton@gmail.com>
To: "Jakarta Commons Users List" <user@commons.apache.org>
Subject: Re: Enhanced DirectoryWalker
In-Reply-To: <15600006.post@talk.nabble.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <15600006.post@talk.nabble.com>

This was been raised before here: http://tinyurl.com/3dmkcl

The one thing that makes me hesitate is it could be confusing since
the user might expect the Collection to be sorted. Anyway, it needs to
be filed as an enhancement request in JIRA - preferably with a patch -
since thats easier to see the proposed changes and to apply:

http://commons.apache.org/io/issue-tracking.html

Niall

On Wed, Feb 20, 2008 at 10:10 PM, Jeff higgins <oohiggins@yahoo.com> wrote:
>
>  Hi,
>  I would like to request a feature enhancement for
>  org.apache.commons.io.DirectoryWalker.
>
>  add sort comparator to walk method
>
>  Thank you for any consideration.
>  Jeff Higgins
>
>
>
>   private final FileFilter defaultFilter;
>   private FileFilter currentFilter;
>   private final int defaultDepthLimit;
>   private int currentDepthLimit;
>   private final Comparator defaultComparator;
>   private Comparator currentComparator;
>
>   protected DirectoryWalker() {
>     this(null, null, -1);
>   }
>
>
>   protected DirectoryWalker(FileFilter defaultFilter,
>       Comparator defaultComparator, int defaultDepthLimit) {
>     this.defaultFilter = defaultFilter;
>     this.currentFilter = this.defaultFilter;
>     this.defaultDepthLimit = defaultDepthLimit;
>     this.currentDepthLimit = this.defaultDepthLimit;
>     this.defaultComparator = defaultComparator;
>     this.currentComparator = this.defaultComparator;
>   }
>
>
>   protected DirectoryWalker(IOFileFilter directoryFilter,
>       IOFileFilter fileFilter, Comparator defaultComparator,
>       int depthLimit) {
>     if (directoryFilter == null && fileFilter == null) {
>       this.defaultFilter = null;
>     } else {
>       directoryFilter = (directoryFilter != null ? directoryFilter
>           : TrueFileFilter.TRUE);
>       fileFilter = (fileFilter != null ? fileFilter : TrueFileFilter.TRUE);
>       directoryFilter = FileFilterUtils.makeDirectoryOnly(directoryFilter);
>       fileFilter = FileFilterUtils.makeFileOnly(fileFilter);
>       this.defaultFilter = FileFilterUtils.orFileFilter(directoryFilter,
>           fileFilter);
>     }
>     this.currentFilter = this.defaultFilter;
>     this.defaultDepthLimit = depthLimit;
>     this.currentDepthLimit = this.defaultDepthLimit;
>     this.defaultComparator = defaultComparator;
>     this.currentComparator = this.defaultComparator;
>   }
>
>
>   protected final void walk(File startDirectory, Collection results)
>       throws IOException {
>     if (startDirectory == null) {
>       throw new NullPointerException("Start Directory is null");
>     }
>     try {
>       handleStart(startDirectory, results);
>       walk(startDirectory, 0, results);
>       handleEnd(results);
>     } catch (CancelException cancel) {
>       handleCancelled(startDirectory, results, cancel);
>     }
>   }
>
>
>   private void walk(File directory, int depth, Collection results)
>       throws IOException {
>
>     checkIfCancelled(directory, depth, results);
>     if (handleDirectory(directory, depth, results)) {
>       handleDirectoryStart(directory, depth, results);
>       int childDepth = depth + 1;
>       if (currentDepthLimit < 0 || childDepth <= currentDepthLimit) {
>         checkIfCancelled(directory, depth, results);
>         File[] childFiles = (currentFilter == null ? directory.listFiles()
>             : directory.listFiles(currentFilter));
>         if (childFiles == null) {
>           handleRestricted(directory, childDepth, results);
>         } else {
>           if (currentComparator != null)
>             Arrays.sort(childFiles, currentComparator);
>           for (int i = 0; i < childFiles.length; i++) {
>             File childFile = childFiles[i];
>             if (childFile.isDirectory()) {
>               walk(childFile, childDepth, results);
>             } else {
>               checkIfCancelled(childFile, childDepth, results);
>               handleFile(childFile, childDepth, results);
>               checkIfCancelled(childFile, childDepth, results);
>             }
>           }
>         }
>       }
>       handleDirectoryEnd(directory, depth, results);
>     }
>     checkIfCancelled(directory, depth, results);
>   }
>
>   public FileFilter getDefaultFilter() {
>     return defaultFilter;
>   }
>
>   public FileFilter getCurrentFilter() {
>     return currentFilter;
>   }
>
>   public void setCurrentFilter(FileFilter filter) {
>     this.currentFilter = filter;
>   }
>
>   public Comparator getDefaultComparator() {
>     return defaultComparator;
>   }
>
>   public Comparator getCurrentComparator() {
>     return currentComparator;
>   }
>
>   public void setCurrentComparator(Comparator comparator) {
>     this.currentComparator = comp;
>   }
>
>   public int getDefaultDepthLimit() {
>     return defaultDepthLimit;
>   }
>
>   public int getCurrentDepthLimit() {
>     return currentDepthLimit;
>   }
>
>   public void setCurrentDepthLimit(int depth) {
>     this.currentDepthLimit = depth;
>   }
>
>
>
>  --
>  View this message in context: http://www.nabble.com/Enhanced-DirectoryWalker-tp15600006p15600006.html
>  Sent from the Commons - User mailing list archive at Nabble.com.
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
>  For additional commands, e-mail: user-help@commons.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org