commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "O'Shea, Sean" <Sean.O'S...@fmr.com>
Subject [commons-pool] Upgrade Question
Date Mon, 07 Jan 2008 19:30:39 GMT
Hi there,

I've recently updated some of my code to use the 1.3 version of
commons-pool. I was previously using a 1.2 version of commons-pool. I
have a class which looks like this:

class PoolHolder extends GenericObjectPool {

    public PoolHolder(ConnectionHolderFactory factory, int maxActive,
            byte whenExhaustedAction, long maxWait, int maxIdle,
            boolean testOnBorrow, boolean testOnReturn, int reapTime,
            boolean testWhileIdle) {
        super(factory,
                maxActive,
                whenExhaustedAction,
                maxWait,
                maxActive,
                0,
                testOnBorrow,
                testOnReturn,
                reapTime,
                0,
                -1,
                true);

}

http://issues.apache.org/bugzilla/show_bug.cgi?id=33264 &
http://issues.apache.org/bugzilla/show_bug.cgi?id=36904 state that the
GenericObjectPool prior to version 1.3 was in fact a LIFO implementation
despite the fact that the documentation stated that it was FIFO. These
bugzilla bugs have been marked as fixed which gives me the impression
that the GenericObjectPool is now a FIFO implementation.

I want to continue to have my PoolHolder class be a LIFO implementation
and I want to use the 1.3 version of commons-pool. Does this mean that I
have to change my class to extend from the StackedObjectPool and remove
references to GenericObjectPool?

Just wanted to check with the community before going ahead with any code
changes on my side.

Cheers

Sean O Shea

---------------------------------------------------------------------
To unsubscribe, e-mail: user-unsubscribe@commons.apache.org
For additional commands, e-mail: user-help@commons.apache.org


Mime
View raw message