commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Anders Kofoed" <anders.kof...@avaleo.net>
Subject Out Of Office until 2nd January 2007
Date Mon, 01 Jan 2007 04:12:34 GMT
Thank you for your mail.
 
Avaleo office is closed from December 23 to January 2 were we will address you request.
If you have urgent requests it's possible to call the following persons:
 
- From December 23th to December 27th (both days included) please call Niels Dyrnesli on +45
40741496.
- From December 28th to January 1 (both days included) please call Anders Kofoed +4529442941
 
Kind regards
Anders Kofoed
Avaleo ApS


-----Original Message-----
Reply-To: "Jakarta Commons Users List" <commons-user@jakarta.apache.org>
Date: Sun, 31 Dec 2006 22:12:01 -0600
From: "Louis Marascio" <marascio@gmail.com>
To: commons-user@jakarta.apache.org
Subject: [FileUpload] Cleaning up temporary files if uploads are aborted

> Hello,

> I'm tinkering with FileUpload v1.1.1 and have the basic upload
> working.  I noticed that if, during an upload, I click the stop button
> in my browser the upload is aborted on the server side appropriately
> w/ an exception. However, the temporary file that was being written by
> the DiskFileItem is not being cleaned up in this situation. I can't
> clean it up from my servlet handler since the FileItem was never added
> to the collection, etc. It appears to be a trivial fix in
> FileUploadBase.parseRequest().  Move the declaration of FileItem
> outside of the try/catch, and, in the catch method do something along
> the lines of:

> if (item != null) item.delete();

> I can submit a patch if desired.  I checked subversion to see how much
> parseRequest() has changed and it appears to have been significantly
> altered.  I'm not sure if there is much value submitting the patch
> against 1.1.1 if a new release is imminent.

> Am I missing something here? Is there some other way to get these
> temporary files cleaned up in the case of an aborted or failed upload?

> Thanks!

> Louis

> -- 
> Louis R. Marascio
> marascio@gmail.com

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-user-help@jakarta.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Mime
View raw message