Mailing-List: contact commons-user-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Users List" <commons-user@jakarta.apache.org>
Received-SPF: pass (asf.osuosl.org: local policy)
From: "Olivier Lamy" <olivier.lamy@accor.com>
To: "'Jakarta Commons Users List'" <commons-user@jakarta.apache.org>
Subject: RE : RE : Log4j String buffer memory Leak.
Date: Wed, 7 Jun 2006 18:16:31 +0200
Message-ID: <007b01c68a4d$bd5c5e60$cad9c839@eu.accor.net>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20060607160241.98519.qmail@web51513.mail.yahoo.com>
Importance: Normal

IMHO,
When you do logger.debug(connectionID + "-" + message);
The string concatenation is evaluated before the call to the logger.
You will find some litterature to this on google.
HTH
--
Olivier


-----Message d'origine-----
De : Naveen [mailto:naween18@yahoo.com]=20
Envoy=E9 : mercredi 7 juin 2006 18:03
=C0 : Jakarta Commons Users List
Objet : Re: RE : Log4j String buffer memory Leak.


yes i use the first one..but will that cause memory leak if my logging
level is turned to INFO
  =20
  Thanks,
  Naveen.

Olivier Lamy <olivier.lamy@accor.com> wrote:
  Simple question=20
You made

logger.debug(connectionID + "-" + message);

Or=20

If (logger.isDebugEnabled())=20
{
logger.debug(connectionID + "-" + message);
}

If using first, you create some String instance for nothing.

--
Olivier

-----Message d'origine-----
De : Naveen [mailto:naween18@yahoo.com]=20
Envoy=E9 : mercredi 7 juin 2006 16:45
=C0 : commons-user@jakarta.apache.org
Objet : Log4j String buffer memory Leak.


Hello all,

Iam not sure if there is really amemory leak in Log4jLogger. We use
Mercury diagnosis tool to find the memory leak and the reports show all
the string buffers being held up at=20

1. org.apache.log4j.Logger.debug=20
2. org.apache.log4j.Logger.info

this is one of the call we make

logger.debug(connectionID + "-" + message);

logger is an instance of Log4j.Logger and connectionID,message are
strings

i know appending strings will internally create StrinBuffers but our
memory reports show string buffers are never cleared which are areated
during that call.

any help is highly appreciated.

Thanks,
Naveen.


Naveen=20

It only takes a moment to be kind, but the results can be everlasting.!!


__________________________________________________
Do You Yahoo!?
Tired of spam? Yahoo! Mail has the best spam protection around=20
http://mail.yahoo.com=20


This e-mail, any attachments and the information contained therein
("this message") are confidential and intended solely for the use of the
addressee(s). If you have received this message in error please send it
back to the sender and delete it. Unauthorized publication, use,
dissemination or disclosure of this message, either in whole or in part
is strictly prohibited.
------------------------------------------------------------------------
--------------------------------------
Ce message =E9lectronique et tous les fichiers joints ainsi que les
informations contenues dans ce message ( ci apr=E8s "le message" ), sont
confidentiels et destin=E9s exclusivement =E0 l'usage de la personne =E0
laquelle ils sont adress=E9s. Si vous avez re=E7u ce message par erreur,
merci de le renvoyer =E0 son =E9metteur et de le d=E9truire. Toutes =
diffusion,
publication, totale ou partielle ou divulgation sous quelque forme que
se soit non express=E9ment autoris=E9es de ce message, sont interdites.
------------------------------------------------------------------------
-------------------------------------


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


    Naveen=20
  =20
  It only takes a moment to be kind, but the results can be
everlasting.!!


 __________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around=20
http://mail.yahoo.com=20


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org