commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Henning P. Schmiedehausen" <...@intermeta.de>
Subject Re: [email] progress on 1.0 release?
Date Thu, 04 Aug 2005 20:23:40 GMT
Simon Kitching <skitching@apache.org> writes:

>And as Troy Poppe mentions, if 35881 is being considered for 1.0 then
>perhaps 34056 should be as well.

For what it is worth, I'd -1 the patch by Troy until he fixed up the

[...]
        try {
            if (StringUtils.isNotEmpty(charset))
            {
//                BROKEN!
//                getPrimaryBodyPart().setText(msg, charset);
                getPrimaryBodyPart().setText(msg);
            }
            else
            {
                getPrimaryBodyPart().setText(msg);
            }
[...]

conditional in MultiPartEmail that his patch introduces. Either get
rid of the conditional or fix up setText(msg, charset). But that hurts
my eyes.

	Regards
		Henning

-- 
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen          INTERMETA GmbH
hps@intermeta.de        +49 9131 50 654 0   http://www.intermeta.de/

RedHat Certified Engineer -- Jakarta Turbine Development  -- hero for hire
   Linux, Java, perl, Solaris -- Consulting, Training, Development

		      4 - 8 - 15 - 16 - 23 - 42

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Mime
View raw message