Mailing-List: contact commons-user-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Users List" <commons-user@jakarta.apache.org>
Received-SPF: pass (hermes.apache.org: domain of oliver.zeigermann@gmail.com
 designates 64.233.184.194 as permitted sender)
DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
        s=beta; d=gmail.com;
        h=received:message-id:date:from:reply-to:to:subject:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
        b=CHjwHpnzH2AqROX4xix2i9oFwu2HBCLnHspH6JBpcKUP2rFc5EM0uV8LLLgbj21d7I04QCvL520LfqvV5PlfjJr3aGugII8vBD1UeyEc7613lioU2SQNfIOrw/1IaClKk9LNDmEG0URoAp25WhxhYfz97TBPGyA8p/czTaD0qS0=
Message-ID: <9da4f45205052310535cc0ad60@mail.gmail.com>
Date: Mon, 23 May 2005 19:53:35 +0200
From: Oliver Zeigermann <oliver.zeigermann@gmail.com>
Reply-To: ozeigermann@apache.org
To: Jakarta Commons Users List <commons-user@jakarta.apache.org>
Subject: Re: [transaction] Duplicate TX id's
In-Reply-To: <4291E6C2.2020506@davidkarlsen.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline
References: <428DE354.3040407@davidkarlsen.com>
	 <9da4f4520505200628603d34e7@mail.gmail.com>
	 <428F5E5E.2070705@davidkarlsen.com>
	 <9da4f45205052305323ab0a2f1@mail.gmail.com>
	 <4291E6C2.2020506@davidkarlsen.com>

On 5/23/05, David J. M. Karlsen <david@davidkarlsen.com> wrote:
> Oliver Zeigermann wrote:
> > On 5/21/05, David J. M. Karlsen <david@davidkarlsen.com> wrote:
> >
> >>Hmm, yeah, but still - I cannot see why txId should be unique, the code=
 is:
> >>
> >>public String generatedUniqueTxId() throws ResourceManagerSystemExcepti=
on {
> >>        assureRMReady();
> >>        String txId;
> >>        synchronized (globalTransactions) {
> >>            do {
> >>                txId =3D Long.toHexString(System.currentTimeMillis);
> >>                // XXX busy loop
> >>            } while (getContext(txId) !=3D null);
> >>        }
> >>        return txId;
> >>    }
> >>
> >
> >
> > It will if you actually use the id to start a new transaction. In this
> > case getContext(txId)  will not return null and the procedure will be
> > repeated.
> It only ensures that you are not given a txId *in use* (eg. started).
> Several equal txId maybe produced by this method - and worse - you will
> only discover this when you try to start the supposedly unique TX. Thus,
> it is broken... It should, as the name implies, generate truly unique id'=
s.

I disagree. The name implies that it generates a truly unique *tx* id,
i.e. a tx id not currently used by any transaction which it does.
=20
> >>you can apply my patch.
> >>It uses doomdark.org 's UUIDGenerator. (the site is down at the moment)=
.
> >
> >
> > I would prefer if you simply generated your ids using this generator
> > without changing the file resource manager code for two reasons:
> that's what I'm doing in my app. (Providing the ID's myself, and not
> calling generateUniqueID).
>=20
> >
> > (1) The above code is not broken
> I beg to differ.
>=20
> > (2) Changing the code would introduce a new dependency to another lib
> True, that is bad. I'll put the generator code into another method that
> we may call. OK?

Depends on the original license of the code.=20

> > (3) The lib's licencse is unclear to me
> I saw it included in some sandbox jakarta code - but that does not
> neccessarily mean the license is OK.

I could not even check what license it has. Which on is it?

Still not convinced ;)

Oliver

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org