commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alik Eliashberg <a...@eliashberg.org>
Subject Re: Statement closing in DbUtils
Date Mon, 01 Nov 2004 19:29:44 GMT
Ah, got it! Do you know when is the next release of DbUtils (that would 
incorporate this fix)?

Thank you,

Alik

David Graham wrote:

>This was fixed some time ago as you can see in the latest source here:
>http://jakarta.apache.org/commons/dbutils/xref/org/apache/commons/dbutils/QueryRunner.html#235
>
>The fix is in the nightly builds.
>
>Thanks,
>David
>
>
>--- Alik Eliashberg <alik@eliashberg.org> wrote:
>
>  
>
>>Hello,
>>
>>I just started using the DbUtils package. I was reading the source code 
>>and I noticed the following potential problem:
>>
>>QueryRunner has a 'finally' clause in'query' method. This clause closes 
>>both ResultSet and the Statement. The problem is that it uses 'close' 
>>not 'closeQuietly'. So it is possible that if the ResultSet close fails,
>>
>>the Statement will remain open forever causing a driver/db resource 
>>leak. Shouldn't the code be rewritten with another nested 'try/finally':
>>   try {
>>      ...
>>   } finally {
>>      try {
>>         DbUtils.close(rs);
>>      } finally {
>>          DbUtils.close(stmt);
>>      }
>>   }
>>[Alternatively, 'closeQuetly' can be used, but that would suppress the 
>>error...]
>>
>>TIA,
>>
>>Alik
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: commons-user-help@jakarta.apache.org
>>
>>
>>    
>>
>
>
>
>		
>__________________________________ 
>Do you Yahoo!? 
>Check out the new Yahoo! Front Page. 
>www.yahoo.com 
> 
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
>For additional commands, e-mail: commons-user-help@jakarta.apache.org
>
>  
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Mime
View raw message