Return-Path: Delivered-To: apmail-jakarta-commons-user-archive@www.apache.org Received: (qmail 70330 invoked from network); 20 Sep 2004 10:33:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (209.237.227.199) by minotaur-2.apache.org with SMTP; 20 Sep 2004 10:33:08 -0000 Received: (qmail 82865 invoked by uid 500); 20 Sep 2004 10:32:57 -0000 Delivered-To: apmail-jakarta-commons-user-archive@jakarta.apache.org Received: (qmail 82697 invoked by uid 500); 20 Sep 2004 10:32:55 -0000 Mailing-List: contact commons-user-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Users List" Reply-To: "Jakarta Commons Users List" Delivered-To: mailing list commons-user@jakarta.apache.org Received: (qmail 82683 invoked by uid 99); 20 Sep 2004 10:32:55 -0000 X-ASF-Spam-Status: No, hits=0.1 required=10.0 tests=FORGED_RCVD_HELO,LOTS_OF_STUFF X-Spam-Check-By: apache.org Received-SPF: pass (hermes.apache.org: local policy) Received: from [217.6.70.103] (HELO mailgw1.picturesafe.de) (217.6.70.103) by apache.org (qpsmtpd/0.28) with ESMTP; Mon, 20 Sep 2004 03:32:51 -0700 Received: from mail.picturesafe.de (unknown [212.76.153.31]) by mailgw1.picturesafe.de (Picturesafe GmbH Mailgateway1) with ESMTP id 4CA9859F92 for ; Mon, 20 Sep 2004 12:32:49 +0200 (CEST) Received: from harry (localhost [127.0.0.1]) by mail (Picturesafe GmbH Mail1) with SMTP id 2EF42311A0 for ; Mon, 20 Sep 2004 12:32:49 +0200 (CEST) Received: from picturesafe.de (pb45.picture-safe.de [212.76.153.45]) by mail.picturesafe.de (Picturesafe GmbH Mail1) with ESMTP id 1102C31181 for ; Mon, 20 Sep 2004 12:32:49 +0200 (CEST) Message-ID: <414EB2F8.60502@picturesafe.de> Date: Mon, 20 Sep 2004 12:37:44 +0200 From: Marco Jacob Organization: Picture/Safe Media Data Bank GmbH User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7b) Gecko/20040421 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Jakarta Commons Users List Subject: Re: Flush by net.ftp.FTPClient.retrieveFile(String, OutputStream) References: <200409081716.i88HGp6B023160@gandalf.savarese.org> In-Reply-To: <200409081716.i88HGp6B023160@gandalf.savarese.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N Hi Daniel, sorry to answer that late. Your fix doesn't do any change to flushing because you left one flush() in line 118 without if(flush). I look forward to your change. Daniel F. Savarese wrote: > In message <413E9DB4.9080701@picturesafe.de>, Marco Jacob writes: >=20 >>In my current case flushing _at the end_ would be no harm. But >=20 >=20 > I was talking about flushing at the end for storeFile only; not > for retrieveFile. And that only because I have vague memories > of some java.io classes not doing the right thing with respect > to writing out their buffers on close in the past. >=20 >=20 >>However, a note that retrieveFile flushes the stream should be in >>the javadoc comment of this method. >=20 >=20 > It won't flush it. I made the change and committed it. Check out > the CVS HEAD and see if it does what you want. The copy buffer > size used by FTPClient should probably be configurable, maybe a > retrieveFile and storeFile that takes a buffer size parameter. >=20 > daniel >=20 >=20 >=20 > --------------------------------------------------------------------- > To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org > For additional commands, e-mail: commons-user-help@jakarta.apache.org >=20 >=20 >=20 --=20 Marco Jacob picturesafe GmbH Software Development L=FCerstra=DFe 3 D-30175 Hannover GERMANY Fon: +49 511 - 856 20 54 Fax: +49 511 - 856 20 10 mailto:mjacob@picturesafe.de --------------------------------------------------------------------- To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-user-help@jakarta.apache.org