Mailing-List: contact commons-user-help@jakarta.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Jakarta Commons Users List" <commons-user@jakarta.apache.org>
Received-SPF: pass (hermes.apache.org: local policy)
Message-ID: <32935.62.251.120.66.1095713399.squirrel@webmail.bibit.com>
Date: Mon, 20 Sep 2004 22:49:59 +0200 (CEST)
Subject: [Pool] Use of Exception in API
From: "Tom van den Berge" <tom.vandenberge@bibit.com>
To: commons-user@jakarta.apache.org
Reply-To: tom.vandenberge@bibit.com
User-Agent: SquirrelMail/1.4.2
MIME-Version: 1.0
Content-Type: text/plain;charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Importance: Normal

Hi,

Hi recently started using the pool API, and I think it's a very useful API.

However I noticed the frequent "throws Exception" declarations, which is
generally bad practice. Many of the core methods in the interfaces declare
it, so automatically all implementations are using it, too.

One example is the borrowObject method from ObjectPool. The implementing
class GenericObjectPool calls a couple of methods from
PoolableObjectFactory, which also throw Exception, and the method itself
also throws an Exception.

Are there any plans scheduled for refactoring these issues throughout the
API?

Since the code is fairly small in size and compact, it shouldn't be too
much effort, and the code will improve greatly. Backward compatibility is
not an issue since you would typically replace the Exceptions with more
specific exceptions.

Regards,
Tom


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org