commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Marco Jacob <mja...@picturesafe.de>
Subject Re: Flush by net.ftp.FTPClient.retrieveFile(String, OutputStream)
Date Mon, 20 Sep 2004 10:37:44 GMT
Hi Daniel,

sorry to answer that late. Your fix doesn't do any change to flushing
because you left one flush() in line 118 without if(flush).

I look forward to your change.

Daniel F. Savarese wrote:

> In message <413E9DB4.9080701@picturesafe.de>, Marco Jacob writes:
> 
>>In my current case flushing _at the end_ would be no harm. But
> 
> 
> I was talking about flushing at the end for storeFile only; not
> for retrieveFile.  And that only because I have vague memories
> of some java.io classes not doing the right thing with respect
> to writing out their buffers on close in the past.
> 
> 
>>However, a note that retrieveFile flushes the stream should be in
>>the javadoc comment of this method.
> 
> 
> It won't flush it.  I made the change and committed it.  Check out
> the CVS HEAD and see if it does what you want.  The copy buffer
> size used by FTPClient should probably be configurable, maybe a
> retrieveFile and storeFile that takes a buffer size parameter.
> 
> daniel
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-user-help@jakarta.apache.org
> 
> 
> 

-- 
Marco Jacob
picturesafe GmbH
Software Development
Lüerstraße 3
D-30175 Hannover
GERMANY

Fon: +49 511 - 856 20 54
Fax: +49 511 - 856 20 10
mailto:mjacob@picturesafe.de


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Mime
View raw message