commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Stephen Colebourne" <scolebou...@btopenworld.com>
Subject Re: [collections] bug in IteratorChain?
Date Tue, 02 Dec 2003 21:15:41 GMT
Unless I'm dreaming, the return was removed not added.
Stephen

----- Original Message -----
From: "pwomack" <pwomack@papermule.co.uk>
> Stephen Colebourne wrote:
> > I have a vague memory of something like this getting fixed once upon a
time.
> > Are you testing against the CVS version of this file or a release?
>
> Oh darn.
>
> It looks like there's a fundemental "nasty", which may require
> thought to fix.
>
> *my* fault is caused in  updateCurrentIterator(),
> which returns IMMEDIATELY after setting
> currentIterator = (Iterator) iteratorChain.get(0);
>
> If this currentIterator is empty, IteratorChain.hasNext() will return
> false, and it's all over.
>
> But this "return" in updateCurrentIterator() was added as a result
> (between v1.2 and 1.3
>
http://cvs.apache.org/viewcvs/jakarta-commons/collections/src/java/org/apach
e/commons/collections/iterators/IteratorChain.java.diff?r1=1.2&r2=1.3&diff_f
ormat=h
>   as result of a bug report:
>
> "fix bug pointed out bu Jonathan Carlson
> add test that demonstrates"
>
> So I guess fixing one bug has caused another.
>
>       BugBear
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-user-help@jakarta.apache.org
>


---------------------------------------------------------------------
To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-user-help@jakarta.apache.org


Mime
View raw message