Return-Path: Delivered-To: apmail-jakarta-commons-user-archive@www.apache.org Received: (qmail 57952 invoked from network); 4 Sep 2003 12:07:58 -0000 Received: from daedalus.apache.org (HELO mail.apache.org) (208.185.179.12) by minotaur-2.apache.org with SMTP; 4 Sep 2003 12:07:58 -0000 Received: (qmail 76045 invoked by uid 500); 4 Sep 2003 12:07:45 -0000 Delivered-To: apmail-jakarta-commons-user-archive@jakarta.apache.org Received: (qmail 76002 invoked by uid 500); 4 Sep 2003 12:07:44 -0000 Mailing-List: contact commons-user-help@jakarta.apache.org; run by ezmlm Precedence: bulk List-Unsubscribe: List-Subscribe: List-Help: List-Post: List-Id: "Jakarta Commons Users List" Reply-To: "Jakarta Commons Users List" Delivered-To: mailing list commons-user@jakarta.apache.org Received: (qmail 75979 invoked from network); 4 Sep 2003 12:07:44 -0000 Received: from unknown (HELO actinium.btinternet.com) (194.73.73.66) by daedalus.apache.org with SMTP; 4 Sep 2003 12:07:44 -0000 Received: from silicon ([194.75.226.12]) by actinium.btinternet.com with esmtp (Exim 3.22 #8) id 19ustp-0006Ni-00 for commons-user@jakarta.apache.org; Thu, 04 Sep 2003 13:07:41 +0100 Received: from 194.164.132.240 by silicon ([194.75.226.12]); Thu, 04 Sep 03 13:07:41 BST Message-ID: <6296146.1062677261702.JavaMail.root@127.0.0.1> Date: Thu, 4 Sep 2003 13:07:41 +0100 (BST) From: scolebourne@btopenworld.com To: commons-user@jakarta.apache.org Subject: Re: [collections] Last call before release 3.0 Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-MAILER: talk21.com WAS v2 X-Spam-Rating: daedalus.apache.org 1.6.2 0/1000/N X-Spam-Rating: minotaur-2.apache.org 1.6.2 0/1000/N I am happy for you to add yourself to collections status.html and project.xml. Any javadoc fixes or extra tests can just be added. If you have an efficiency improvement thats fine too, so long as it doesn't change existing functionality. The aims of 3.0 are just to release the CVS. I'd stay clear of primitives until that debate is complete. The main changes are the addition of the decorators and observed subpackages - decorators could definitely use more testing. Stephen > from: Phil Steitz > Stephen, > > I have started reviewing code, javadoc and test coverage and I have > found a few javadoc errors, some test coverage gaps and a few other odds > and ends. Should I submit patches for the tests and javadoc fixes or > just apply them? I am happy to help either way. > > Here is one code change that I would recommend: > > Currently, CollectionUtils.isProperSubCollection(a,b) returns > > CollectionUtils.isSubCollection(a,b) && > (!(CollectionUtils.isEqualCollection(a,b))); > > This is very inefficient, since it is equivalent to > > (a.size() < b.size()) && CollectionUtils.isSubCollection(a,b); > > There are currently no tests for this method, but the latter works for > the ones that I have coded. > > So that I can prioritize my efforts, can you provide a list of exactly > what is going in 3.0 (or point me to the right thread -- sorry I have > not been following Collections too closely). > > Phil > > > > Stephen Colebourne wrote: > > This is the last call for all [collections] issues, bugs, patches to be > > raised before [collections] version 3 is created. > > > > I'm currently aiming at a 2-3 week timetable, so you'll have to be quick. If > > you want to help, checking CVS/nightly build for javadoc issues or other > > minor issues would be most welcome. > > > > Please note that the main coordination of changes and the release will be on > > the commons-dev mailing list. > > > > Here's hoping for a successful release real soon... > > > > Stephen > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org > > For additional commands, e-mail: commons-user-help@jakarta.apache.org > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org > For additional commands, e-mail: commons-user-help@jakarta.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org For additional commands, e-mail: commons-user-help@jakarta.apache.org