commons-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Craig R. McClanahan" <craig...@apache.org>
Subject Re: [logging] [patch] making logging applet-friendly
Date Tue, 15 Jul 2003 15:48:57 GMT
Sounds reasonable to me.  I committed your patch with a slight variation,
to catch and ignore just SecurityException instead of Throwable.  This
should show up in tonight's nightly builds, and will be in the next
release whenever that happens.

Craig

On Tue, 15 Jul 2003, Paul Libbrecht wrote:

> Date: Tue, 15 Jul 2003 17:23:48 +0200
> From: Paul Libbrecht <paul@activemath.org>
> Reply-To: Jakarta Commons Users List <commons-user@jakarta.apache.org>
> To: Jakarta Commons Users List <commons-user@jakarta.apache.org>
> Subject: [logging] [patch] making logging applet-friendly
>
>
> Hi there,
>
> To me Jakarta-logging is a saviour in the process of writing sandboxed
> things such as applets or webstart sandboxed applications: we dare use
> log4j for our servers but can turn to the very simple jakarta-logging
> when deploying over the client (log4j is a catastrophe for applets btw).
>
> Everything is fine except... the static initialization of SimpleLog.java
> wich calls a getProperty on a property that is not allowed...
>
> So here's my patch: catch the getProperty()'s possible throws by just
> considering the proprety is not there.
>
> Here's the method, line 161 of SimpleLog.java:
>
>      private static String getStringProperty(String name) {
>          String prop = null;
>          try {
>              prop = System.getProperty(name);
>          } catch (Throwable t) {} // ignore...
>          return (prop == null) ? simpleLogProps.getProperty(name) : prop;
>      }
>
>
> Should I make a real unidiff patch for that ?
>
> thanks.
>
> Paul
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: commons-user-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: commons-user-help@jakarta.apache.org
>
>

Mime
View raw message